mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Andy Yan <andyshrk@163.com>
Cc: vkoul@kernel.org, linux-phy@lists.infradead.org,
	 cristian.ciocaltea@collabora.com,
	Andy Yan <andy.yan@rock-chips.com>,
	 joro@8bytes.org, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	 linux-rockchip@lists.infradead.org, heiko@sntech.de,
	 dri-devel@lists.freedesktop.org, cl@rock-chips.com,
	 linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org,  detlev.casanova@collabora.com,
	hjc@rock-chips.com, krzk+dt@kernel.org
Subject: Re: [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support
Date: Sat, 28 Dec 2024 08:09:05 -0600	[thread overview]
Message-ID: <173539494517.1967895.2732995549466236200.robh@kernel.org> (raw)
In-Reply-To: <20241228122155.646957-6-andyshrk@163.com>


On Sat, 28 Dec 2024 20:21:48 +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> Add vop found on rk3576, the main difference between rk3576 and the
> previous vop is that each VP has its own interrupt line.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> 
> ---
> 
> Changes in v2:
> - describe constraint SOC by SOC, as interrupts of rk3576 is very
>   different from others
> - Drop Krzysztof's Reviewed-by, as this version changed a lot.
> 
> Changes in v1:
> - ordered by soc name
> - Add description for newly added interrupt
> 
>  .../display/rockchip/rockchip-vop2.yaml       | 70 +++++++++++++++----
>  1 file changed, 56 insertions(+), 14 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml: properties:interrupts: {'minItems': 1, 'maxItems': 4, 'items': [{'description': 'vop system interrupt, such as bus error, and vsync for vop version under rk3576.'}, {'description': 'independent interrupts for each video port, such as vsync and other video port related error interrupts.'}]} should not be valid under {'required': ['maxItems']}
	hint: "maxItems" is not needed with an "items" list
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241228122155.646957-6-andyshrk@163.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-12-28 14:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-28 12:21 [PATCH v2 0/8] Add display subsystem dt node on rk3576 Andy Yan
2024-12-28 12:21 ` [PATCH v2 1/8] dt-bindings: soc: rockchip: add rk3576 hdptxphy grf syscon Andy Yan
2024-12-28 12:21 ` [PATCH v2 2/8] dt-bindings: phy: Add rk3576 hdptx phy Andy Yan
2024-12-28 12:21 ` [PATCH v2 3/8] dt-bindings: display: rockchip: Add rk3576 hdmi controller Andy Yan
2024-12-28 12:21 ` [PATCH v2 4/8] dt-bindings: iommu: rockchip: Add Rockchip RK3576 Andy Yan
2024-12-28 12:21 ` [PATCH v2 5/8] dt-bindings: display: vop2: Add rk3576 support Andy Yan
2024-12-28 14:09   ` Rob Herring (Arm) [this message]
2024-12-29 10:13   ` Krzysztof Kozlowski
2024-12-29 10:49     ` Andy Yan
2024-12-31  8:23       ` Krzysztof Kozlowski
2024-12-31  8:43         ` Andy Yan
2024-12-28 12:21 ` [PATCH v2 6/8] arm64: dts: rockchip: Add vop for rk3576 Andy Yan
2024-12-28 12:21 ` [PATCH v2 7/8] arm64: dts: rockchip: Add hdmi " Andy Yan
2024-12-28 12:21 ` [PATCH v2 8/8] arm64: dts: rockchip: Enable hdmi display on sige5 Andy Yan
2024-12-28 18:36 ` [PATCH v2 0/8] Add display subsystem dt node on rk3576 Heiko Stübner
2024-12-29  6:48   ` Andy Yan
2024-12-29 14:35     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173539494517.1967895.2732995549466236200.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy.yan@rock-chips.com \
    --cc=andyshrk@163.com \
    --cc=cl@rock-chips.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®