mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Andrew Morton <akpm@osdl.org>
Cc: "Jan Beulich" <JBeulich@novell.com>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@muc.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] CONFIG_UNWIND_INFO
Date: Wed, 18 Jan 2006 22:48:57 +1100	[thread overview]
Message-ID: <17358.11049.367188.552649@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20060114045635.1462fb9e.akpm@osdl.org>

Andrew Morton writes:

> If you do a `make oldconfig' with CONFIG_DEBUG_KERNEL you get
> -fasynchronous-unwind-tables and (on my yellowdog-4 toolchain at least) the
> ppc64 kernel doesn't like that one bit. 
> 
> 
> EXT3-fs: mounted filesystem with ordered data mode.
> ADDRCONF(NETDEV_UP): eth0: link is not ready
> tg3: eth0: Link is up at 100 Mbps, full duplex.
> tg3: eth0: Flow control is off for TX and off for RX.
> ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> autofs: Unknown ADD relocation: 44
> sunrpc: Unknown ADD relocation: 44

We aren't handling R_PPC64_REL64 relocations in our module code.  This
patch (completely untested :) might help.

Paul.

diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module_64.c
index 928b858..4885f39 100644
--- a/arch/powerpc/kernel/module_64.c
+++ b/arch/powerpc/kernel/module_64.c
@@ -337,6 +337,10 @@ int apply_relocate_add(Elf64_Shdr *sechd
 			*(unsigned long *)location = value;
 			break;
 
+		case R_PPC64_REL64:
+			*location = value - (unsigned long) location;
+			break;
+
 		case R_PPC64_TOC:
 			*(unsigned long *)location = my_r2(sechdrs, me);
 			break;

  parent reply	other threads:[~2006-01-18 11:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08 12:59 Jan Beulich
2006-01-14 12:56 ` Andrew Morton
2006-01-14 14:03   ` Sam Ravnborg
2006-01-16  7:36     ` Jan Beulich
2006-01-16  7:46       ` Andrew Morton
2006-01-18 11:48   ` Paul Mackerras [this message]
2006-01-18 15:18     ` Andi Kleen
2006-01-18 15:58       ` Jan Beulich
2006-01-18 16:11         ` Andi Kleen
2006-01-18 16:48           ` Jan Beulich
2006-01-20  4:47       ` Paul Mackerras
2006-01-20  6:13         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17358.11049.367188.552649@cargo.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=JBeulich@novell.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®