From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: irenic.rajneesh@gmail.com, david.e.box@intel.com,
hdegoede@redhat.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, xi.pardee@linux.intel.com,
"David E. Box" <david.e.box@linux.intel.com>
Subject: Re: [PATCH] platform/x86/intel/pmc: Fix ioremap of bad address
Date: Tue, 07 Jan 2025 17:59:55 +0200 [thread overview]
Message-ID: <173626559524.4330.18207834156877167581.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250106174653.1497128-1-david.e.box@linux.intel.com>
On Mon, 06 Jan 2025 09:46:52 -0800, David E. Box wrote:
> In pmc_core_ssram_get_pmc(), the physical addresses for hidden SSRAM
> devices are retrieved from the MMIO region of the primary SSRAM device. If
> additional devices are not present, the address returned is zero.
> Currently, the code does not check for this condition, resulting in ioremap
> incorrectly attempting to map address 0. Add a check for a zero address and
> return 0 if no additional devices are found, as it is not an error for the
> device to be absent.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86/intel/pmc: Fix ioremap of bad address
commit: 1d7461d0c8330689117286169106af6531a747ed
--
i.
prev parent reply other threads:[~2025-01-07 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 17:46 David E. Box
2025-01-07 15:59 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173626559524.4330.18207834156877167581.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=irenic.rajneesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=xi.pardee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®