From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Esteban Blanc <eblanc@baylibre.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtc: tps6594: Fix integer overflow on 32bit systems
Date: Mon, 13 Jan 2025 00:21:21 +0100 [thread overview]
Message-ID: <173672406962.1487447.9603474833606557636.b4-ty@bootlin.com> (raw)
In-Reply-To: <1074175e-5ecb-4e3d-b721-347d794caa90@stanley.mountain>
On Wed, 11 Dec 2024 12:32:34 +0300, Dan Carpenter wrote:
> The problem is this multiply in tps6594_rtc_set_offset()
>
> tmp = offset * TICKS_PER_HOUR;
>
> The "tmp" variable is an s64 but "offset" is a long in the
> (-277774)-277774 range. On 32bit systems a long can hold numbers up to
> approximately two billion. The number of TICKS_PER_HOUR is really large,
> (32768 * 3600) or roughly a hundred million. When you start multiplying
> by a hundred million it doesn't take long to overflow the two billion
> mark.
>
> [...]
Applied, thanks!
[1/1] rtc: tps6594: Fix integer overflow on 32bit systems
https://git.kernel.org/abelloni/c/09c4a6101532
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-01-12 23:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 9:32 Dan Carpenter
2024-12-11 11:51 ` Andy Shevchenko
2024-12-11 12:29 ` Dan Carpenter
2025-01-12 23:21 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173672406962.1487447.9603474833606557636.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=eblanc@baylibre.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®