From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD35E1FC7E7 for ; Tue, 14 Jan 2025 18:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736878207; cv=none; b=ctBwxjbOrqOS+y+Foa5sQKn64zOPX2EBERMHMyAuUlbJQ8E2NxafdBSdoRd94i5cRPEjy/fdGdEj1YEd9cqD3/0zr5l3b+ggqdO6B/tlhn4rj1rUJlDH6Dx9QmWJbf/G98UfFSSZoGGVW9+M918anLXbgY67w0KqUbX1NFqhvYM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736878207; c=relaxed/simple; bh=xt2EUpR+Drgf9WZVcSI4e/bScCfCLpE0kwHYQgg2tlA=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=iAllNM/lemtpvzs/AOy24OH+okjqja4UPg0Jbr+0wo8C+QMAWxbuOI2wn5ChYBUg6MrYq7dG6zkcDkSQJSaNOhmDhGP6z2rZg5ZpRh8VSpD1j/k4rZZK55DSdjikBULK5eFti2FN+uEWu2mxA5MUc+PfFjrh0BQJBG4oXjoM+y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=TtUt0xtu; arc=none smtp.client-ip=209.85.166.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="TtUt0xtu" Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-3cdce23f3e7so43372645ab.0 for ; Tue, 14 Jan 2025 10:10:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1736878205; x=1737483005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gaooOFOGtKSVaMzqMlIyw6V93Yl6VrFQA2qk2SuiUTE=; b=TtUt0xtuXiHuJP68t7ijiM7HYbc7asuyQ5pGEpIIs8tdrVYj2NmppEcTVP/bgitnZq xtD+WvLdP6yOkq+lDyhxUNAhhydjF+0L0LBnVTsBoGFYV4PUZc4Dg+GS4Uu7JPDAp+l6 RjpQuXfnZdsfCR3a+4ph0FcnorA733EAqIi46Lid/UjYQhBer9Rs+IK9RpLHx0pA0mOV R9mO7Az7a4/z/WGTUtxs/ewr+VTMv1EjOEIvm7gB2qUbybbIpN6QPALVjwel5QX3csSH Ob54G3ptt2K3I6jHdrnR6Mw0boubc9ILcSjo/J2tCHnCSICMKMDFQypSZDSuoSwAZXCs bYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736878205; x=1737483005; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gaooOFOGtKSVaMzqMlIyw6V93Yl6VrFQA2qk2SuiUTE=; b=Mby8sBHpVFp97kDCwtAuhUMify6MSFO1poMFVv1tSnYAjnhKd17piFUvBaMsgtyKwS MStKRBcyPurZGcIKfXFowuTmx00zLT/1lTkqtzjivn+xe0gDkm6LcESZSFgJfR73qSo5 Cmfb9+JMWbCgqUC1MYFxQanivlIMUTniKNGYQXMh7mDfrsJhLAbdt1lnrv4DVgrhOkfl cAT8BS3RiXmWEJRyDDcz+HX2dhhmby6/O1WXK5c3hmI1jTMOni+Z3jCRiWDpQgDJbraP m1wShIMhD4vAmtKrDBlzMezmD1AYwZGN78+Ny0XNpNdGUqIqLRoxU7PGooB5qqb1E8kU Viuw== X-Gm-Message-State: AOJu0YyMDZ4yiezNpcXT0mmogczYg9Q+vde4Y1znBw0m3HSgTFw7EbYw clL4lUiUAdegGstVkYIuoSskJhj9bNv3CtFcFhA9cbeujnRWNNPfCuFrmhvboVKArgo7FYwhRCs C X-Gm-Gg: ASbGnctxl8Mm4muJsqF/7GXL9QN7D7ts9PnY1gRpK1ZDRXHj/0nigUTNPpmPh87eCSA FiUfDrAZpf27doKF0ujK7CpGIc8Wcz4AZeuov3ajQ3MkGIVX0Gx8BHDCw5UUD7vomXcWl3/+MFN YM/Sw3lJRAOuN16xP46ObirfGjKgapHqpxHBoqThPlXNUqIRb9q0v6GkoFZxNFBA5J6dW8O6QHH tLQyAahwzMnHVJ766F1og19elLRsj55QH16ne6oBfjSwp4= X-Google-Smtp-Source: AGHT+IESxb4ZBWnQjANqv633zPRNwgXlL5qp0koS0neZNYlYqJdfFfgNSI/Dd5CsOfd6P4zPzpKMpw== X-Received: by 2002:a05:6e02:1f8a:b0:3cc:b7e4:6264 with SMTP id e9e14a558f8ab-3ce3a892c05mr203910065ab.0.1736878205032; Tue, 14 Jan 2025 10:10:05 -0800 (PST) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3ce6c1fc60dsm18220165ab.7.2025.01.14.10.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 10:10:04 -0800 (PST) From: Jens Axboe To: Pavel Begunkov , io-uring@vger.kernel.org, Jann Horn Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <20250114-uring-check-accounting-v1-1-42e4145aa743@google.com> References: <20250114-uring-check-accounting-v1-1-42e4145aa743@google.com> Subject: Re: [PATCH] io_uring/rsrc: require cloned buffers to share accounting contexts Message-Id: <173687820427.1326090.9681462149230294879.b4-ty@kernel.dk> Date: Tue, 14 Jan 2025 11:10:04 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-14bd6 On Tue, 14 Jan 2025 18:49:00 +0100, Jann Horn wrote: > When IORING_REGISTER_CLONE_BUFFERS is used to clone buffers from uring > instance A to uring instance B, where A and B use different MMs for > accounting, the accounting can go wrong: > If uring instance A is closed before uring instance B, the pinned memory > counters for uring instance B will be decremented, even though the pinned > memory was originally accounted through uring instance A; so the MM of > uring instance B can end up with negative locked memory. > > [...] Applied, thanks! [1/1] io_uring/rsrc: require cloned buffers to share accounting contexts commit: 19d340a2988d4f3e673cded9dde405d727d7e248 Best regards, -- Jens Axboe