From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6563186E58 for ; Mon, 20 Jan 2025 18:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737396428; cv=none; b=uAMvNFydxmxd/Pgk6+vrbkJ2Z1kHOwCCj42JVO3t80grNEWl9yX/bvpOCiPShdXYPBljA6LO4cAOFtvoy6XKqyPk6HcU9VpDRjwCMyxcCtzZlsOVobEhGJTnq0T4E3jLIw4suVJZm8wsh36j+ne+nWdKH5dZu0FhsexKrYXI9BM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737396428; c=relaxed/simple; bh=8AdyMzVl3VyDGO8YGEbcZY38N6ptSUkUngU1LwT4/ik=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=EKRfZh2puoWvIx0uhqmtFfjzBXiaq3RewYmoMqTyCfC4x3PYyjjcFS8gpWsgfn1R8yRLNZ8ab13kjV5US7PViso/SWgwMlPO4b642hJEl3XFLKqvp654LJt/olCMbAhKrgR4wE6d9J7vKqCSru1D11YHygsssVJzf5hWuHHvrWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=wkZAwit1; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="wkZAwit1" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-844cd85f5ebso383044439f.3 for ; Mon, 20 Jan 2025 10:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1737396424; x=1738001224; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tc6EjsY8XkMBH4MPv8CRSs+PVzget+pwyf0+O80F6gI=; b=wkZAwit1/9DhYwcvlgfDSsZySc5dUwv54Rsnwlj1jFbUEz1srYKpZ92nDRU+obm8Y8 6zKgSWleqp3R500F8TA+13SOGLiuaJd8/icWlkaKJDJAre1dp66PuPJyFRdKHoxohZE8 RLefVQKnolCKeGEdkusuD7xtxTn4yzoBnmOByVnBma1Wb/Jjdye8Tj8ERAhFCnZG8h1J jKbltXL709EgE8JpBMuDlMbO+10gy4N8Gx4IN51Dy2LPfKunbCkTmxVXThPrbOZ/w1fx c2XRorOQYoNNz7OovGYFR0Lms62m37g+GinAwbTCn/dY4zX16SVj+cUvYy+/UrJOxaRC 3Nnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737396424; x=1738001224; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tc6EjsY8XkMBH4MPv8CRSs+PVzget+pwyf0+O80F6gI=; b=Mis3skEAzlVC9Jknd4nAx2QNeppT5qXduApRMJjxCxpTADtZx0rg0QcISmAm7SBmV/ mg+3yCdF5BvSIDfZYsgK8PC2GqvHoJhPkoIjw9GPH78UPQCYut8rufW8Faj2nB9HYuqD 7Bf2J+bfcSzhi9bv3qiIQKpqscKuaD3+tzX+y6Ykzvjk4wU1IoBHWLBI7ir7FpkBVkMI NZwYRzjBJH46Aq2vm8K1CA82Iq5QG5WtDIXsIpuReyCZgF75m0Y1z99vUSVfqFJPXZYV 9cGfd5aj82XkoTRZIg+jhhzbcG8wsPzqTaQK0AgQFgNiSSv+dGOruDz3Exy79H3BQyqK NKOw== X-Forwarded-Encrypted: i=1; AJvYcCWkmin1r7mX8GD/dwB5Q0+YsbB4i0ex+ifZBm0ZYO4JQu+zMelw7n7fOgghllEbZlITmngaLdXrA3VAwY0=@vger.kernel.org X-Gm-Message-State: AOJu0YwIbd61iFhp117ROsSfummuq4volxmhzPOkSqkAu+TpyEHWVldF MY1n0BgPCcx4n8Rc6LyLTlZKuyoXhrTS2qIg20K2kYH3cqdSmo55sU2NSRCczTg= X-Gm-Gg: ASbGncv/r7fKD2Z/oNhC08aynAXHgyPJKiaYH0eBT5dM5j7Zyckfwkl2L3Wt1baAOLj Pr9GBwRgTXWUUZE+0DBU+viTaOQ/ikptiUwaj5waP8aIiFRKn1XftG69JaAanBPwKWAngBU4lO0 ms7D71tB8hKRt+Z8+qnrpF5SDIHR/84EnM5/I7bC1fBYaumOkPmxOGmTx9QYaKzjs68TZDhosJz ne7DfAn6Bovc1cFyngHU52rhRlSRsOcjBAUW1mfu9w+RxteMxk9DPMh9SKXlevNyMvddk5N X-Google-Smtp-Source: AGHT+IGPw5HyUk2SgXUvSBgUaH4W6NMJLND5LcuhdKNVUETW9RBbUW2uvTreOCdvMesDSPA7wm1JIg== X-Received: by 2002:a05:6602:394a:b0:844:debf:2b42 with SMTP id ca18e2360f4ac-851b619fc96mr1314858539f.2.1737396423709; Mon, 20 Jan 2025 10:07:03 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea756bae75sm2661825173.132.2025.01.20.10.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 10:07:02 -0800 (PST) From: Jens Axboe To: Pavel Begunkov , Jann Horn Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20250120-uring-lockdep-assert-earlier-v1-1-68d8e071a4bb@google.com> References: <20250120-uring-lockdep-assert-earlier-v1-1-68d8e071a4bb@google.com> Subject: Re: [PATCH] io_uring/rsrc: Move lockdep assert from io_free_rsrc_node() to caller Message-Id: <173739642251.137076.1833330906555536038.b4-ty@kernel.dk> Date: Mon, 20 Jan 2025 11:07:02 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3-dev-14bd6 On Mon, 20 Jan 2025 17:21:57 +0100, Jann Horn wrote: > Checking for lockdep_assert_held(&ctx->uring_lock) in io_free_rsrc_node() > means that the assertion is only checked when the resource drops to zero > references. > Move the lockdep assertion up into the caller io_put_rsrc_node() so that it > instead happens on every reference count decrement. > > > [...] Applied, thanks! [1/1] io_uring/rsrc: Move lockdep assert from io_free_rsrc_node() to caller commit: 8c4b2fd5908d2260dfac8d4b74aae1bb5deea379 Best regards, -- Jens Axboe