mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Basharath Hussain Khaja <basharath@couthit.com>,
	Saravana Kannan <saravanak@google.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] of: address: Fix empty resource handling in __of_address_resource_bounds()
Date: Fri, 24 Jan 2025 16:00:05 -0600	[thread overview]
Message-ID: <173775596409.2511219.13763390679214460358.robh@kernel.org> (raw)
In-Reply-To: <20250120-of-address-overflow-v1-1-dd68dbf47bce@linutronix.de>


On Mon, 20 Jan 2025 15:09:40 +0100, Thomas Weißschuh wrote:
> "resource->end" needs to always be equal to "resource->start + size - 1".
> The previous version of the function did not perform the "- 1" in case
> of an empty resource.
> 
> Also make sure to allow an empty resource at address 0.
> 
> Reported-by: Basharath Hussain Khaja <basharath@couthit.com>
> Closes: https://lore.kernel.org/lkml/20250108140414.13530-1-basharath@couthit.com/
> Fixes: 1a52a094c2f0 ("of: address: Unify resource bounds overflow checking")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
>  drivers/of/address.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 

Applied, thanks!

Please resend the kunit test with 0-day issues fixed.

Rob

  reply	other threads:[~2025-01-24 22:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 14:09 [PATCH 0/2] " Thomas Weißschuh
2025-01-20 14:09 ` [PATCH 1/2] " Thomas Weißschuh
2025-01-24 22:00   ` Rob Herring (Arm) [this message]
2025-01-20 14:09 ` [PATCH 2/2] of: address: Add kunit test for __of_address_resource_bounds() Thomas Weißschuh
2025-01-20 19:31   ` kernel test robot
2025-01-21  1:57   ` kernel test robot
2025-01-26  9:59   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173775596409.2511219.13763390679214460358.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=basharath@couthit.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saravanak@google.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®