From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Ike Panhc <ike.pan@canonical.com>,
Hans de Goede <hdegoede@redhat.com>,
Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Kurt Borja <kuurtb@gmail.com>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
Mario Limonciello <mario.limonciello@amd.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] platform/x86: ideapad-laptop: pass a correct pointer to the driver data
Date: Tue, 28 Jan 2025 14:20:43 +0200 [thread overview]
Message-ID: <173806684396.1748.12048181273043599788.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250127210202.568691-1-pchelkin@ispras.ru>
On Tue, 28 Jan 2025 00:02:01 +0300, Fedor Pchelkin wrote:
> devm_platform_profile_register() expects a pointer to the private driver
> data but instead an address of the pointer variable is passed due to a
> typo. This leads to the crashes later:
>
> BUG: unable to handle page fault for address: 00000000fe0d0044
> PGD 0 P4D 0
> Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI
> CPU: 6 UID: 0 PID: 1284 Comm: tuned Tainted: G W 6.13.0+ #7
> Tainted: [W]=WARN
> Hardware name: LENOVO 21D0/LNVNB161216, BIOS J6CN45WW 03/17/2023
> RIP: 0010:__mutex_lock.constprop.0+0x6bf/0x7f0
> Call Trace:
> <TASK>
> dytc_profile_set+0x4a/0x140 [ideapad_laptop]
> _store_and_notify+0x13/0x40 [platform_profile]
> class_for_each_device+0x145/0x180
> platform_profile_store+0xc0/0x130 [platform_profile]
> kernfs_fop_write_iter+0x13e/0x1f0
> vfs_write+0x290/0x450
> ksys_write+0x6c/0xe0
> do_syscall_64+0x82/0x160
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: ideapad-laptop: pass a correct pointer to the driver data
commit: 9a9b61337751ed9e6827b467771f6e880b5c733c
--
i.
prev parent reply other threads:[~2025-01-28 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 21:02 Fedor Pchelkin
2025-01-27 21:20 ` Kurt Borja
2025-01-28 12:20 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173806684396.1748.12048181273043599788.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ike.pan@canonical.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mario.limonciello@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=pchelkin@ispras.ru \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®