mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Michal Wilczynski <m.wilczynski@samsung.com>
Cc: guoren@kernel.org, krzk+dt@kernel.org, aou@eecs.berkeley.edu,
	 airlied@gmail.com, wefu@redhat.com, ulf.hansson@linaro.org,
	 jszhang@kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, jassisinghbrar@gmail.com,
	 linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 linux-clk@vger.kernel.org, palmer@dabbelt.com,
	 maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	 mturquette@baylibre.com, p.zabel@pengutronix.de,
	m.szyprowski@samsung.com,  linux-riscv@lists.infradead.org,
	simona@ffwll.ch, drew@pdp7.com,  frank.binns@imgtec.com,
	conor+dt@kernel.org, tzimmermann@suse.de,  sboyd@kernel.org,
	paul.walmsley@sifive.com, matt.coster@imgtec.com
Subject: Re: [PATCH v4 12/18] dt-bindings: gpu: Add support for T-HEAD TH1520 GPU
Date: Tue, 28 Jan 2025 19:42:17 -0600	[thread overview]
Message-ID: <173811493702.543459.14627465568650161345.robh@kernel.org> (raw)
In-Reply-To: <20250128194816.2185326-13-m.wilczynski@samsung.com>


On Tue, 28 Jan 2025 20:48:10 +0100, Michal Wilczynski wrote:
> Add bindings for the PowerVR BXM-4-64 GPU integrated in the T-HEAD
> TH1520 SoC.  This GPU requires two clocks.
> 
> Document the integration details including clock, reset, power domain
> and interrupt assignments. Add a dt-bindings example showing the proper
> usage of the compatible string "thead,th1520-gpu" along with
> "img,img-bxm".
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
> ---
>  .../bindings/gpu/img,powervr-rogue.yaml       | 39 +++++++++++++++++--
>  1 file changed, 35 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/gpu/img,powervr-rogue.example.dts:46.28-29 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/gpu/img,powervr-rogue.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250128194816.2185326-13-m.wilczynski@samsung.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-01-29  1:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250128194825eucas1p14e2cb0a85c397dea297e9c4177cf1585@eucas1p1.samsung.com>
2025-01-28 19:47 ` [PATCH v4 00/18] Enable drm/imagination BXM-4-64 Support for LicheePi 4A Michal Wilczynski
     [not found]   ` <CGME20250128194826eucas1p1b18e5af64e66b06da985b194d022273c@eucas1p1.samsung.com>
2025-01-28 19:47     ` [PATCH v4 01/18] dt-bindings: clock: thead: Add TH1520 VO clock controller Michal Wilczynski
2025-01-29  7:29       ` Krzysztof Kozlowski
     [not found]   ` <CGME20250128194827eucas1p25db822456e223563b8b411f77754c760@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 02/18] clk: thead: Add clock support for VO subsystem in T-Head TH1520 SoC Michal Wilczynski
2025-01-31 15:39       ` Matt Coster
2025-02-03 16:37         ` Michal Wilczynski
     [not found]   ` <CGME20250128194829eucas1p279fb146417854b28366378793087694a@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 03/18] dt-bindings: firmware: thead,th1520: Add support for firmware node Michal Wilczynski
2025-01-29  7:30       ` Krzysztof Kozlowski
     [not found]   ` <CGME20250128194830eucas1p134d566631b5622c85d843f5d811c3c00@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 04/18] firmware: thead: Add AON firmware protocol driver Michal Wilczynski
2025-02-14 11:01       ` Ulf Hansson
     [not found]   ` <CGME20250128194831eucas1p258522118b2f21abd8f6d4cdde277fe07@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 05/18] dt-bindings: power: Add TH1520 SoC power domains Michal Wilczynski
2025-01-29  7:31       ` Krzysztof Kozlowski
     [not found]   ` <CGME20250128194832eucas1p15db9ed3575703812ecc0374ffc5b2861@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 06/18] pmdomain: thead: Add power-domain driver for TH1520 Michal Wilczynski
2025-02-14 11:15       ` Ulf Hansson
     [not found]   ` <CGME20250128194834eucas1p2f7581075b9f238c84e83c5fa210bc3ea@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 07/18] riscv: Enable PM_GENERIC_DOMAINS for T-Head SoCs Michal Wilczynski
     [not found]   ` <CGME20250128194835eucas1p29b16bee72365f321e1056fc4d9d44345@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 08/18] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller Michal Wilczynski
2025-01-29  7:32       ` Krzysztof Kozlowski
     [not found]   ` <CGME20250128194836eucas1p151c4fc83a17173fd1b79bfc959976301@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 09/18] reset: thead: Add TH1520 reset controller driver Michal Wilczynski
2025-01-29 12:04       ` Philipp Zabel
2025-01-31 15:39       ` Matt Coster
2025-02-03 18:15         ` Michal Wilczynski
2025-02-04 17:18           ` Philipp Zabel
2025-02-10 18:17             ` Michal Wilczynski
2025-02-11 11:59               ` Philipp Zabel
     [not found]   ` <CGME20250128194838eucas1p1829115b2b05d209a7c277eccf56e0b90@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 10/18] drm/imagination: Add reset controller support for GPU initialization Michal Wilczynski
2025-01-31 15:39       ` Matt Coster
     [not found]   ` <CGME20250128194839eucas1p1885da20ddfec840341879c120a21f514@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 11/18] dt-bindings: gpu: Add 'resets' property " Michal Wilczynski
2025-01-31 15:39       ` Matt Coster
     [not found]   ` <CGME20250128194841eucas1p29048dc05a26475d8323a7a318a8c7a25@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 12/18] dt-bindings: gpu: Add support for T-HEAD TH1520 GPU Michal Wilczynski
2025-01-29  1:42       ` Rob Herring (Arm) [this message]
2025-01-31 15:39       ` Matt Coster
2025-02-03 17:58         ` Michal Wilczynski
     [not found]   ` <CGME20250128194842eucas1p2aa8df6d985786c17432feca390861918@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 13/18] drm/imagination: Add support for IMG BXM-4-64 GPU Michal Wilczynski
2025-01-31 15:39       ` Matt Coster
     [not found]   ` <CGME20250128194843eucas1p28e5e735e526a153138c3539a9ceeec07@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 14/18] drm/imagination: Enable PowerVR driver for RISC-V Michal Wilczynski
     [not found]   ` <CGME20250128194845eucas1p1c05f74ffbfc62da048615f7dd2781b4b@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 15/18] riscv: dts: thead: Add device tree VO clock controller Michal Wilczynski
     [not found]   ` <CGME20250128194846eucas1p1bb40288d32401ecd32410f05a811cc3b@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 16/18] riscv: dts: thead: Introduce power domain nodes with aon firmware Michal Wilczynski
     [not found]   ` <CGME20250128194847eucas1p29f83672bd54d3e8ba76c1d5f53f1dc4b@eucas1p2.samsung.com>
2025-01-28 19:48     ` [PATCH v4 17/18] riscv: dts: thead: Introduce reset controller node Michal Wilczynski
     [not found]   ` <CGME20250128194849eucas1p1c957dedd293b3091d8dfb35bdfa1fb0c@eucas1p1.samsung.com>
2025-01-28 19:48     ` [PATCH v4 18/18] riscv: dts: thead: Add GPU node to TH1520 device tree Michal Wilczynski
2025-01-31 15:39   ` [PATCH v4 00/18] Enable drm/imagination BXM-4-64 Support for LicheePi 4A Matt Coster
2025-02-03 16:33     ` Michal Wilczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173811493702.543459.14627465568650161345.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drew@pdp7.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=guoren@kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=m.wilczynski@samsung.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=sboyd@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=ulf.hansson@linaro.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®