mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Basharath Hussain Khaja <basharath@couthit.com>,
	Saravana Kannan <saravanak@google.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] of: address: Add kunit test for __of_address_resource_bounds()
Date: Wed, 29 Jan 2025 10:48:22 -0600	[thread overview]
Message-ID: <173816930010.2216376.7589401365931628062.robh@kernel.org> (raw)
In-Reply-To: <20250129-of-address-overflow-v3-1-95d1760ed791@linutronix.de>


On Wed, 29 Jan 2025 14:35:27 +0100, Thomas Weißschuh wrote:
> The overflow checking has to deal with different datatypes and
> edgecases. Add a new kunit testcase to make sure it works correctly.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Changes in v3:
> - Avoid constant truncation warnings by using u64 for test case
>   expectations
> - Run through 0day before submission
> - Link to v2: https://lore.kernel.org/r/20250127-of-address-overflow-v2-1-61b5046044e9@linutronix.de
> 
> Changes in v2:
> - Rebase on robh/for-master
> - Drop already applied patch
> - Add missing MODULE_IMPORT_NS()
> - Fix sparse warnings: "cast truncates bits from constant value"
> - Link to v1: https://lore.kernel.org/r/20250120-of-address-overflow-v1-0-dd68dbf47bce@linutronix.de
> ---
> Technically it's possible to run this unittest with !CONFIG_OF_ADDRESS,
> so there is an explicit check inside the test.
> It would also be possible to add a dedicated source file, but that
> seemed like a lot of churn to me.
> ---
>  drivers/of/address.c    |   5 +-
>  drivers/of/of_private.h |   4 ++
>  drivers/of/of_test.c    | 119 +++++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 126 insertions(+), 2 deletions(-)
> 

Applied, thanks!


      reply	other threads:[~2025-01-29 16:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 13:35 Thomas Weißschuh
2025-01-29 16:48 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173816930010.2216376.7589401365931628062.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=basharath@couthit.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saravanak@google.com \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®