From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C242E772A1 for ; Thu, 5 Oct 2023 16:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234840AbjJEQIk (ORCPT ); Thu, 5 Oct 2023 12:08:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239406AbjJEQHJ (ORCPT ); Thu, 5 Oct 2023 12:07:09 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCE395EC85 for ; Thu, 5 Oct 2023 08:54:07 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-405505b07dfso14121175e9.0 for ; Thu, 05 Oct 2023 08:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent.com; s=google; t=1696521246; x=1697126046; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F9jgX1V/4Lt7reawNBa64mpmNNW6z5NJmtuZCopzjTg=; b=RdPs6bZCzTnzBDxtlGbBLZYrAXpWrVAqfCJrQjL459cvkqcCFqNtPhHtRBAwn5I8kH nfQAuZhDmuHS1+nDaiCuiLbJR2h1BieddU2ZSBvOt67/EnEtUp3zHl6333g5L3aRABeI c84o55OR0SNgsy338YXtivt4XS5bwzlDpJA5FfaRnPufkbpPg3bOgAdOvCKXtnTihsMj RXxgmzCCTuwjZ1aJD/7JkbJuC6sN/RMEnf3E9Uf/CUT2/2GplY8b1XT8JZFgF/20KZim hBAxChOohMgtPD7eTpDlABCwibgKK+0BuXdrGfpW9kfJNuxzQRyR9eN9OXuBq0WWzjvX J0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696521246; x=1697126046; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F9jgX1V/4Lt7reawNBa64mpmNNW6z5NJmtuZCopzjTg=; b=U9wD6zNHeJZGpYTSaapwwN4NLkTSf5WI2YWO25iH9jA4Abf6GkmlvDAiqvGd0T2LHD 6dm/vOW4hQtMq1Sim7rhlttwTJOHJ2eYQA1H8azImvvgpLITMxqwpl3udPqFS0mcZBGU MPuhIs+iUinjsQGfWWfQlW+tyARi1poHouYkuivo/vL/ljDapAetnE9MUUeyhFIcu5lO CgFDd3nu/7f03qWsEwqEqq96brd+IVx98dnln/Umny6hcE/4eagl7K7T2SxIa512cBRe MDL9vehcQFhawK7UCX+cFlvof7yGfmZdzb46QLJnUaQtEZ/jRw+d7zYONG9ROGOYk4Rw 8OJQ== X-Gm-Message-State: AOJu0YwI3fj+v1oQVf9clIuYM9o08xQJugm7jzE1ZYCah5zSDO6y2hFS foc6bWjSHt7NOadaZMSzlfnKcw== X-Google-Smtp-Source: AGHT+IH2BebPRq+/LzX2/VVJ5f5eYcre8Nkr1mAjsJbh/Lmum/1uCIr+dEfwSuRrKcNBSRmGFfuaog== X-Received: by 2002:a5d:4e42:0:b0:313:f75b:c552 with SMTP id r2-20020a5d4e42000000b00313f75bc552mr2619252wrt.15.1696521246096; Thu, 05 Oct 2023 08:54:06 -0700 (PDT) Received: from ?IPV6:2a02:8011:e80c:0:4a49:8ee5:5e5c:cfd5? ([2a02:8011:e80c:0:4a49:8ee5:5e5c:cfd5]) by smtp.gmail.com with ESMTPSA id p3-20020a5d4583000000b0032008f99216sm2070696wrq.96.2023.10.05.08.54.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 08:54:05 -0700 (PDT) Message-ID: <173829f3-817e-4937-808f-7f9bfc22207f@isovalent.com> Date: Thu, 5 Oct 2023 16:54:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] bpftool: Align bpf_load_and_run_opts insns and data Content-Language: en-GB To: Ian Rogers , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231004222323.3503030-1-irogers@google.com> <20231004222323.3503030-2-irogers@google.com> From: Quentin Monnet In-Reply-To: <20231004222323.3503030-2-irogers@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2023 23:23, Ian Rogers wrote: > A C string lacks alignment so use aligned arrays to avoid potential > alignment problems. Switch to using sizeof (less 1 for the \0 > terminator) rather than a hardcode size constant. > > Signed-off-by: Ian Rogers > --- > tools/bpf/bpftool/gen.c | 47 ++++++++++++++++++++++------------------- > 1 file changed, 25 insertions(+), 22 deletions(-) > > diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c > index b8ebcee9bc56..7a545dcabe38 100644 > --- a/tools/bpf/bpftool/gen.c > +++ b/tools/bpf/bpftool/gen.c > @@ -408,8 +408,8 @@ static void codegen(const char *template, ...) > /* skip baseline indentation tabs */ > for (n = skip_tabs; n > 0; n--, src++) { > if (*src != '\t') { > - p_err("not enough tabs at pos %td in template '%s'", > - src - template - 1, template); > + p_err("not enough tabs at pos %td in template '%s'\n'%s'", > + src - template - 1, template, src); Nit: This line is no longer aligned with the opening parenthesis. Other than that: Acked-by: Quentin Monnet