From: "Rob Herring (Arm)" <robh@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Stanislav Jakubek <stano.jakubek@gmail.com>
Subject: Re: [PATCH v3 2/7] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054
Date: Fri, 31 Jan 2025 13:41:56 -0600 [thread overview]
Message-ID: <173835251253.3936353.15748613970933991457.robh@kernel.org> (raw)
In-Reply-To: <20250131-bcm59054-v3-2-bbac52a84787@gmail.com>
On Fri, 31 Jan 2025 19:13:50 +0100, Artur Weber wrote:
> The BCM59054 MFD is fairly similar to the BCM59056, and will use
> the same driver. Add compatible and specify the allowed regulator
> nodes.
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
> Changes in v3:
> - Split regulator node into separate file
> - Removed quotes around compatible
> ---
> .../devicetree/bindings/mfd/brcm,bcm59056.yaml | 26 +++++++++-
> .../bindings/regulator/brcm,bcm59054.yaml | 55 ++++++++++++++++++++++
> 2 files changed, 79 insertions(+), 2 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml: ^(cam|sim|mmc)ldo[1-2]$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml: ^(rf|sd|sdx|aud|mic|usb|vib|tcx)ldo$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml: ^(c|mm|v)sr$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml: ^(io|sd)sr[1-2]$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml: ^gpldo[1-3]$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml: ^lvldo[1-2]$: Missing additionalProperties/unevaluatedProperties constraint
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/brcm,bcm59054.yaml: vbus: Missing additionalProperties/unevaluatedProperties constraint
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250131-bcm59054-v3-2-bbac52a84787@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-01-31 19:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 18:13 [PATCH v3 0/7] mfd: bcm590xx: Add support " Artur Weber
2025-01-31 18:13 ` [PATCH v3 1/7] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2025-02-02 9:56 ` Stanislav Jakubek
2025-02-02 13:27 ` Krzysztof Kozlowski
2025-02-04 18:33 ` Artur Weber
2025-01-31 18:13 ` [PATCH v3 2/7] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2025-01-31 19:41 ` Rob Herring (Arm) [this message]
2025-02-02 10:08 ` Stanislav Jakubek
2025-02-02 13:24 ` Krzysztof Kozlowski
2025-02-05 17:58 ` Artur Weber
2025-01-31 18:13 ` [PATCH v3 3/7] ARM: dts: Drop DTS for BCM59056 PMIC Artur Weber
2025-01-31 18:13 ` [PATCH v3 4/7] mfd: bcm590xx: Add compatible for BCM59054 Artur Weber
2025-02-07 8:48 ` Lee Jones
2025-02-07 13:06 ` Artur Weber
2025-02-10 16:33 ` Lee Jones
2025-01-31 18:13 ` [PATCH v3 5/7] regulator: bcm590xx: Store regulator descriptions in table Artur Weber
2025-01-31 18:13 ` [PATCH v3 6/7] regulator: bcm590xx: Rename BCM59056-specific data as such Artur Weber
2025-01-31 18:13 ` [PATCH v3 7/7] regulator: bcm590xx: Add support for BCM59054 regulators Artur Weber
2025-02-05 19:12 ` Stanislav Jakubek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173835251253.3936353.15748613970933991457.robh@kernel.org \
--to=robh@kernel.org \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®