mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Ravi Bangoria" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Ravi Bangoria <ravi.bangoria@amd.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Namhyung Kim <namhyung@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/core] perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros
Date: Mon, 03 Feb 2025 12:48:20 -0000	[thread overview]
Message-ID: <173858690094.10177.4993434304735211612.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250115054438.1021-2-ravi.bangoria@amd.com>

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     003c0414318a1829a1a5b195ad81e8a7960c3f5d
Gitweb:        https://git.kernel.org/tip/003c0414318a1829a1a5b195ad81e8a7960c3f5d
Author:        Ravi Bangoria <ravi.bangoria@amd.com>
AuthorDate:    Wed, 15 Jan 2025 05:44:30 
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Mon, 03 Feb 2025 11:46:04 +01:00

perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros

Definition of these macros are very simple and they are used at only one
place. Get rid of unnecessary redirection.

Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/r/20250115054438.1021-2-ravi.bangoria@amd.com
---
 arch/x86/events/amd/ibs.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c
index e7a8b87..4ca8006 100644
--- a/arch/x86/events/amd/ibs.c
+++ b/arch/x86/events/amd/ibs.c
@@ -28,9 +28,6 @@ static u32 ibs_caps;
 #include <asm/nmi.h>
 #include <asm/amd-ibs.h>
 
-#define IBS_FETCH_CONFIG_MASK	(IBS_FETCH_RAND_EN | IBS_FETCH_MAX_CNT)
-#define IBS_OP_CONFIG_MASK	IBS_OP_MAX_CNT
-
 /* attr.config2 */
 #define IBS_SW_FILTER_MASK	1
 
@@ -688,7 +685,7 @@ static struct perf_ibs perf_ibs_fetch = {
 		.read		= perf_ibs_read,
 	},
 	.msr			= MSR_AMD64_IBSFETCHCTL,
-	.config_mask		= IBS_FETCH_CONFIG_MASK,
+	.config_mask		= IBS_FETCH_MAX_CNT | IBS_FETCH_RAND_EN,
 	.cnt_mask		= IBS_FETCH_MAX_CNT,
 	.enable_mask		= IBS_FETCH_ENABLE,
 	.valid_mask		= IBS_FETCH_VAL,
@@ -711,7 +708,7 @@ static struct perf_ibs perf_ibs_op = {
 		.read		= perf_ibs_read,
 	},
 	.msr			= MSR_AMD64_IBSOPCTL,
-	.config_mask		= IBS_OP_CONFIG_MASK,
+	.config_mask		= IBS_OP_MAX_CNT,
 	.cnt_mask		= IBS_OP_MAX_CNT | IBS_OP_CUR_CNT |
 				  IBS_OP_CUR_CNT_RAND,
 	.enable_mask		= IBS_OP_ENABLE,

  reply	other threads:[~2025-02-03 12:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15  5:44 [PATCH v4 0/9] perf/amd/ibs: Fix sample period computations Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 1/9] perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros Ravi Bangoria
2025-02-03 12:48   ` tip-bot2 for Ravi Bangoria [this message]
2025-01-15  5:44 ` [PATCH v4 2/9] perf/amd/ibs: Remove pointless sample period check Ravi Bangoria
2025-02-03 12:48   ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 3/9] perf/amd/ibs: Fix ->config to sample period calculation for OP PMU Ravi Bangoria
2025-02-03 12:48   ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 4/9] perf/amd/ibs: Fix perf_ibs_op.cnt_mask for CurCnt Ravi Bangoria
2025-02-03 12:48   ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 5/9] perf/amd/ibs: Don't allow freq mode event creation through ->config interface Ravi Bangoria
2025-01-16 21:09   ` Peter Zijlstra
2025-01-17  4:51     ` Ravi Bangoria
2025-02-03 12:48   ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 6/9] perf/amd/ibs: Add PMU specific minimum period Ravi Bangoria
2025-02-03 12:48   ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 7/9] perf/amd/ibs: Add ->check_period() callback Ravi Bangoria
2025-02-03 12:48   ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 8/9] perf/amd/ibs: Ceil sample_period to min_period Ravi Bangoria
2025-02-03 12:48   ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2025-01-15  5:44 ` [PATCH v4 9/9] perf test amd ibs: Add sample period unit test Ravi Bangoria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=173858690094.10177.4993434304735211612.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®