From: "tip-bot2 for Vladimir Kondratiev" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
Thomas Gleixner <tglx@linutronix.de>,
Anup Patel <anup@brainfault.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] irqchip/riscv-aplic: Add support for hart indexes
Date: Mon, 03 Feb 2025 13:37:01 -0000 [thread overview]
Message-ID: <173858982178.10177.3135949933325527742.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250129091637.1667279-3-vladimir.kondratiev@mobileye.com>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: b93afe8a3ac53ae52296d65acfaa9c5f582a48cc
Gitweb: https://git.kernel.org/tip/b93afe8a3ac53ae52296d65acfaa9c5f582a48cc
Author: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
AuthorDate: Wed, 29 Jan 2025 11:16:37 +02:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 03 Feb 2025 14:27:39 +01:00
irqchip/riscv-aplic: Add support for hart indexes
RISC-V APLIC specification defines "hart index" in:
https://github.com/riscv/riscv-aia
Within a given interrupt domain, each of the domain’s harts has a unique
index number in the range 0 to 2^14 − 1 (= 16,383). The index number a
domain associates with a hart may or may not have any relationship to the
unique hart identifier (“hart ID”) that the RISC-V Privileged Architecture
assigns to the hart. Two different interrupt domains may employ entirely
different index numbers for the same set of harts.
Further, this document says in "4.5 Memory-mapped control region for an
interrupt domain":
The array of IDC structures may include some for potential hart index
numbers that are not actual hart index numbers in the domain. For example,
the first IDC structure is always for hart index 0, but 0 is not
necessarily a valid index number for any hart in the domain.
Support arbitrary hart indices specified in an optional APLIC property
"riscv,hart-indexes" which is specified as an array of u32 elements, one
per interrupt target. If this property is not specified, fallback to use
logical hart indices within the domain.
Signed-off-by: Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/all/20250129091637.1667279-3-vladimir.kondratiev@mobileye.com
---
drivers/irqchip/irq-riscv-aplic-direct.c | 24 ++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-riscv-aplic-direct.c b/drivers/irqchip/irq-riscv-aplic-direct.c
index 7cd6b64..205ad61 100644
--- a/drivers/irqchip/irq-riscv-aplic-direct.c
+++ b/drivers/irqchip/irq-riscv-aplic-direct.c
@@ -31,7 +31,7 @@ struct aplic_direct {
};
struct aplic_idc {
- unsigned int hart_index;
+ u32 hart_index;
void __iomem *regs;
struct aplic_direct *direct;
};
@@ -219,6 +219,20 @@ static int aplic_direct_parse_parent_hwirq(struct device *dev, u32 index,
return 0;
}
+static int aplic_direct_get_hart_index(struct device *dev, u32 logical_index,
+ u32 *hart_index)
+{
+ const char *prop_hart_index = "riscv,hart-indexes";
+ struct device_node *np = to_of_node(dev->fwnode);
+
+ if (!np || !of_property_present(np, prop_hart_index)) {
+ *hart_index = logical_index;
+ return 0;
+ }
+
+ return of_property_read_u32_index(np, prop_hart_index, logical_index, hart_index);
+}
+
int aplic_direct_setup(struct device *dev, void __iomem *regs)
{
int i, j, rc, cpu, current_cpu, setup_count = 0;
@@ -265,8 +279,12 @@ int aplic_direct_setup(struct device *dev, void __iomem *regs)
cpumask_set_cpu(cpu, &direct->lmask);
idc = per_cpu_ptr(&aplic_idcs, cpu);
- idc->hart_index = i;
- idc->regs = priv->regs + APLIC_IDC_BASE + i * APLIC_IDC_SIZE;
+ rc = aplic_direct_get_hart_index(dev, i, &idc->hart_index);
+ if (rc) {
+ dev_warn(dev, "hart index not found for IDC%d\n", i);
+ continue;
+ }
+ idc->regs = priv->regs + APLIC_IDC_BASE + idc->hart_index * APLIC_IDC_SIZE;
idc->direct = direct;
aplic_idc_set_delivery(idc, true);
next prev parent reply other threads:[~2025-02-03 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 11:38 [PATCH v4 0/2] riscv,aplic: " Vladimir Kondratiev
2025-01-09 11:38 ` [PATCH v4 1/2] dt-bindings: interrupt-controller: add risc-v,aplic " Vladimir Kondratiev
2025-01-10 16:20 ` Rob Herring
2025-01-12 7:47 ` Vladimir Kondratiev
2025-01-10 16:22 ` Rob Herring
2025-01-12 8:38 ` Vladimir Kondratiev
2025-01-27 17:52 ` Thomas Gleixner
2025-01-29 9:16 ` [PATCH v5 0/2] riscv,aplic: support for " Vladimir Kondratiev
2025-01-29 9:16 ` [PATCH v5 1/2] dt-bindings: interrupt-controller: add risc-v,aplic " Vladimir Kondratiev
2025-01-29 16:40 ` Rob Herring (Arm)
2025-02-03 13:37 ` [tip: irq/core] dt-bindings: interrupt-controller: Add " tip-bot2 for Vladimir Kondratiev
2025-01-29 9:16 ` [PATCH v5 2/2] irqchip/riscv-aplic: add support for " Vladimir Kondratiev
2025-02-03 13:37 ` tip-bot2 for Vladimir Kondratiev [this message]
2025-01-09 11:38 ` [PATCH v4 " Vladimir Kondratiev
2025-01-20 9:57 ` [PATCH v4 0/2] riscv,aplic: " Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173858982178.10177.3135949933325527742.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=anup@brainfault.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=vladimir.kondratiev@mobileye.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®