From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D46B20A5C8; Mon, 3 Feb 2025 15:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738597029; cv=none; b=YER1qjWbxA/JJ24q7aA3mlba+xCRvPWhGox/cVZn7ymh3EaDXDjcNjsQ7QKXKT4Qt1p4+bmr+NU7vbbE7wLrs+hE4u+dPOXMpzd5McAXaH0/+0b52JdE2JM/Vu0VW7s4TnrRIAJMol52qWprCH/59F4klGRssyXbhunEeU5j35c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738597029; c=relaxed/simple; bh=sfylPJubRQa0RsghaJs13B2uvS7uCwVTb+ajboSxtWM=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=OyXIR7qzJUYdbaWV4daWyj7nSmEwBsE3G0HHqwl4fmBQL3Rk4kIhKB+YKhoEtdtkOJyYYr72TH/Pc/qAjdAEW2Kg43TA6OtJizNSQEDF5hlZGkhEB86596BWMiVAfts+82UBj0oIQWE3du+cLA9kWNeWf3SVN/9iRNfTUW/hylA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YCK/gJmV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YCK/gJmV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25DD6C4CEEA; Mon, 3 Feb 2025 15:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738597029; bh=sfylPJubRQa0RsghaJs13B2uvS7uCwVTb+ajboSxtWM=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=YCK/gJmVBhifud6DyjAyqCdAxRrF7cHgL4t8K3otG7aGJNb8BezDkPAWV52oWm96i NP8kEmTjdvlHphyAE9zaUzZxdaUbb8mfZTwrhkexfx1qF30I5RqPZKJVPYwSIxLo/G MO5HSCjKAINSSNM3R1jICWiHJeR9Imgy6rb3JVdcUc1wIjgrpI0DiZeIIXEqe0D9Wu PQQ4GvxWrz1oFigbTwmeLKJPB6qYUKyIMdUJHtpyzcJJruHcYvyymBnjb0EP00jC/6 3VyaWDBUPXzeCILbG5vlhI9FDggngsZWP9QSbQARAZ/J92MHKBZCNUakrRuGTeVRrW LodTL9/akGChg== Date: Mon, 03 Feb 2025 09:37:08 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: Christian Hewitt , Kevin Hilman , Artur Weber , Karl Chan , devicetree@vger.kernel.org, Martin Blumenstingl , ~postmarketos/upstreaming@lists.sr.ht, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Conor Dooley , Jerome Brunet , Neil Armstrong To: Ferass El Hafidi In-Reply-To: <20250203091453.15751-1-funderscore@postmarketos.org> References: <20250203091453.15751-1-funderscore@postmarketos.org> Message-Id: <173859694815.2601688.2854626525832601939.robh@kernel.org> Subject: Re: [PATCH v3 0/2] Add support for Xiaomi Mi TV Stick On Mon, 03 Feb 2025 09:14:51 +0000, Ferass El Hafidi wrote: > This patch series aims to add initial support for the Xiaomi Mi TV > Stick. > > Xiaomi Mi TV Stick is a small Amlogic-based Android TV stick released in > 2020, and known as `xiaomi-aquaman` internally (in the downstream kernel, > u-boot, ...) > Its specifications are as follows: > * Amlogic S805Y SoC (believed to be mostly identical to S805X) > * 8 GB eMMC > * 1 GB of RAM > * Android TV 9, upgradable to Android TV 10 > > There are multiple variants: > * 1. Green PCB, manufactured in 2020, known UART pinout (helpfully > labeled on the board) > * 2. Blue PCB, not much documentation about it, presumably manufactured > between 2021 and 2023 > * 3. Green PCB, manufactured in 2023, known UART pinout, some layout > changes compared to the 2020 variant > > Among these variants, there are many boards using multiple different > Wi-Fi chips. Supporting all of them is out of scope for this patch > series. > > As of the time of writing this has only been tested on the 3rd variant. > It is believed that software-wise all three work mostly the same (if we > don't count Wi-Fi), but testing on the other variants would still be > appreciated. > > The devicetree is based on the Amlogic P241 DTS. > > Changes since v2 [1]: > * fix SoB/From mismatch > > Changes since v1 [2]: > * remove useless nodes: cvbs-connector, ethmac, internal_phy, ir > * add `amlogic,s805y` DT binding section > * add S805Y dtsi: meson-gxl-s805y.dtsi > * adjust DT `model` to "Xiaomi Mi TV Stick (Aquaman)" > * explain the changes being done a bit more in the commit message for > the DT patch > * drop `clocks` and `clock-names` from pwm_ef (background: [3]) > * change sound `model` to "XIAOMI-AQUAMAN" > > [1]: https://lore.kernel.org/all/20250201193044.28856-1-funderscore@postmarketos.org/ > [2]: https://lore.kernel.org/all/20250131200319.19996-1-funderscore@postmarketos.org/ > [3]: https://lore.kernel.org/linux-amlogic/20241227212514.1376682-1-martin.blumenstingl@googlemail.com/ > > Ferass El Hafidi (2): > dt-bindings: arm: amlogic: add S805Y and Mi TV Stick > arm64: dts: amlogic: add support for xiaomi-aquaman/Mi TV Stick > > .../devicetree/bindings/arm/amlogic.yaml | 7 + > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../meson-gxl-s805y-xiaomi-aquaman.dts | 288 ++++++++++++++++++ > .../boot/dts/amlogic/meson-gxl-s805y.dtsi | 10 + > 4 files changed, 306 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s805y-xiaomi-aquaman.dts > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s805y.dtsi > > -- > 2.47.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250203091453.15751-1-funderscore@postmarketos.org: arch/arm64/boot/dts/amlogic/meson-gxl-s805y-xiaomi-aquaman.dtb: phy@78000: 'vbus-supply' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/phy/amlogic,meson-gxl-usb2-phy.yaml#