From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4329A208995; Mon, 3 Feb 2025 15:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738597031; cv=none; b=l7ImUPm5RbBq2scRBpfbzz5lMjr56ywqe/gR09KNeQH4im3bp2roxNaIaLDQ7UwWjyfgzG6zi+Ne9PVMHG4xMSBJ30BZmMOKTAYRrnAEEsJUIdM9GhXz3JO83NKXOKrjkCq6dgubgleOXlpurOy+kQ0136mhRmz3Wi3zlC2W4OU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738597031; c=relaxed/simple; bh=zxuCVc3egPezHDqToqET5g5++zkJ6jbKo4UuMIaT+WQ=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=c1Wf49OnMFoI/eXEyONtTSSVEkZgw2y3+X0gxB/lj418//3HTq58uW/qGisOv/mfeMotNooOtZd5R9GvrCuf/kUXk23hI6t/jAnPJg0Iy5xOVMOQD6NN4rhQ+pJn3f5WJ26uNl253joQDXLgt5L36slEkSOZLTG3/Su0AXASmzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IN275eiC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IN275eiC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91200C4CED2; Mon, 3 Feb 2025 15:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738597030; bh=zxuCVc3egPezHDqToqET5g5++zkJ6jbKo4UuMIaT+WQ=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=IN275eiCLwwUJezABuTmgS/US0CW0NZ1G/NPDhDwL0OEXm9WFnsDHjXtv3CUH1K/m gnLsaN11HXs/h+hRoYeIBYDx5d1K2Muckr4/8MK7KYcKT8DNAvdxQ0lS673B9Q31af 9mYoDVPwUB5n6Jpys8Ad5YoevQXO6zg+F95xCEN8lQKLfB+3/HtWXwTTybFP84jZQy SxDr1iRDQwF3ls3f/aDfoyvmQLMTSGnJZMxk6Iad3TjfBMmfinoCNHRLiGRL4aWrJ9 CvpyxtkZg1F87bHwO+tHTkBibNedX7Mktf1+Qd/xhp+Gh3l/7/Ff1hsTZfdheqhila lxdB+s965rIEg== Date: Mon, 03 Feb 2025 09:37:09 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: linus.walleij@linaro.org, netdev@vger.kernel.org, openipmi-developer@lists.sourceforge.net, minyard@acm.org, brgl@bgdev.pl, linux-kernel@vger.kernel.org, andrew@codeconstruct.com.au, edumazet@google.com, davem@davemloft.net, andrew+netdev@lunn.ch, joel@jms.id.au, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eajames@linux.ibm.com, krzk+dt@kernel.org, kuba@kernel.org, pabeni@redhat.com, linux-aspeed@lists.ozlabs.org To: Ninad Palsule In-Reply-To: <20250203144422.269948-1-ninad@linux.ibm.com> References: <20250203144422.269948-1-ninad@linux.ibm.com> Message-Id: <173859694889.2601726.10618336219726193824.robh@kernel.org> Subject: Re: [PATCH v7 0/9] DTS updates for system1 BMC On Mon, 03 Feb 2025 08:44:10 -0600, Ninad Palsule wrote: > Hello, > > Please review the patch set version 7. > > V7: > --- > - Updated pattern in the ast2400-gpio.yaml > - Dropped "dt-bindings: net: faraday,ftgmac100" patch sending it > separately. > > V6: > --- > - Fixed dt_binding_check errors for ipmb-dev.yaml > - Changed the hog parsing pattern in ast2400-gpio > > V5: > --- > - Improved IPBM device documentation. > - Added the hog parsing in ast2400-gpio > > V4: > --- > - Removed "Add RGMII support" patch as it needs some work from the > driver side. > - Improved IPBM device documentation. > - There is a new warning in CHECK_DTBS which are false positive so > ignored them. > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: gpio@1e780000: 'hog-0', 'hog-1', 'hog-2', 'hog-3' do not match any of the regexes: 'pinctrl-[0-9]+' > > V3: > --- > - Fixed dt_binding_check warnings in ipmb-dev.yaml > - Updated title and description in ipmb-dev.yaml file. > - Updated i2c-protocol description in ipmb-dev.yaml file. > > V2: > --- > Fixed CHECK_DTBS errors by > - Using generic node names > - Documenting phy-mode rgmii-rxid in ftgmac100.yaml > - Adding binding documentation for IPMB device interface > > NINAD PALSULE (6): > ARM: dts: aspeed: system1: Add IPMB device > ARM: dts: aspeed: system1: Add GPIO line name > ARM: dts: aspeed: system1: Reduce sgpio speed > ARM: dts: aspeed: system1: Update LED gpio name > ARM: dts: aspeed: system1: Remove VRs max8952 > ARM: dts: aspeed: system1: Mark GPIO line high/low > > Ninad Palsule (3): > bindings: ipmi: Add binding for IPMB device intf > dt-bindings: gpio: ast2400-gpio: Add hogs parsing > ARM: dts: aspeed: system1: Disable gpio pull down > > .../bindings/gpio/aspeed,ast2400-gpio.yaml | 6 + > .../devicetree/bindings/ipmi/ipmb-dev.yaml | 56 +++++++ > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 139 +++++++++++------- > 3 files changed, 147 insertions(+), 54 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml > > -- > 2.43.0 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/aspeed/' for 20250203144422.269948-1-ninad@linux.ibm.com: arch/arm/boot/dts/aspeed/aspeed-bmc-opp-palmetto.dtb: gpio@1e780000: 'pin_func_mode0', 'pin_func_mode1', 'pin_func_mode2', 'pin_gpio_a0', 'pin_gpio_a1', 'pin_gpio_b1', 'pin_gpio_b2', 'pin_gpio_b7', 'pin_gpio_d1', 'pin_gpio_f1', 'pin_gpio_f4', 'pin_gpio_f5', 'pin_gpio_f7', 'pin_gpio_g3', 'pin_gpio_g4', 'pin_gpio_g5', 'pin_gpio_h0', 'pin_gpio_h1', 'pin_gpio_h2', 'pin_gpio_h7' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-opp-romulus.dtb: gpio@1e780000: 'nic_func_mode0', 'nic_func_mode1', 'seq_cont' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dtb: gpio@1e780000: 'doom-guardrail' does not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dtb: gpio@1e780000: 'pin_gpio_aa6', 'pin_gpio_aa7', 'pin_gpio_ab0', 'pin_gpio_b0', 'pin_gpio_b5', 'pin_gpio_h5', 'pin_gpio_z2' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-bytedance-g220a.dtb: gpio@1e780000: 'pin_gpio_b6', 'pin_gpio_i3' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: gpio@1e780000: 'usb_power' does not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-bytedance-g220a.dtb: /ahb/apb/bus@1e78a000/interrupt-controller@0: failed to match any schema with compatible: ['aspeed,ast2500-i2c-ic'] arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dtb: gpio@1e780000: 'bmc-ready' does not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtjade.dtb: gpio@1e780000: 'bmc-ready' does not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dtb: gpio@1e780000: 'i2c3_mux_oe_n', 'usb_power' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-1s4u.dtb: gpio@1e780000: 'i2c3_mux_oe_n', 'usb_power' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dtb: gpio@1e780000: 'i2c3_mux_oe_n', 'usb_power' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-bonnell.dtb: gpio@1e780000: 'usb_power' does not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-opp-nicole.dtb: gpio@1e780000: 'func_mode0', 'func_mode1', 'func_mode2', 'ncsi_cfg', 'seq_cont' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-lenovo-hr855xg2.dtb: gpio@1e780000: 'pin_gpio_a1', 'pin_gpio_a3', 'pin_gpio_aa0', 'pin_gpio_aa4', 'pin_gpio_ab3', 'pin_gpio_ac6', 'pin_gpio_b5', 'pin_gpio_b7', 'pin_gpio_e0', 'pin_gpio_e2', 'pin_gpio_e5', 'pin_gpio_e6', 'pin_gpio_f0', 'pin_gpio_f1', 'pin_gpio_f2', 'pin_gpio_f3', 'pin_gpio_f4', 'pin_gpio_f6', 'pin_gpio_g7', 'pin_gpio_h6', 'pin_gpio_i3', 'pin_gpio_j1', 'pin_gpio_j2', 'pin_gpio_j3', 'pin_gpio_l0', 'pin_gpio_l1', 'pin_gpio_l4', 'pin_gpio_l5', 'pin_gpio_r6', 'pin_gpio_r7', 'pin_gpio_s1', 'pin_gpio_s2', 'pin_gpio_s6', 'pin_gpio_z3' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-lenovo-hr630.dtb: gpio@1e780000: 'pin_gpio_aa0', 'pin_gpio_aa5', 'pin_gpio_b5', 'pin_gpio_f0', 'pin_gpio_f3', 'pin_gpio_f4', 'pin_gpio_f5', 'pin_gpio_g4', 'pin_gpio_g7', 'pin_gpio_h2', 'pin_gpio_h3', 'pin_gpio_i3', 'pin_gpio_j2', 'pin_gpio_j3', 'pin_gpio_s2', 'pin_gpio_s4', 'pin_gpio_s6', 'pin_gpio_y0', 'pin_gpio_y1', 'pin_gpio_z0', 'pin_gpio_z2', 'pin_gpio_z3', 'pin_gpio_z7' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-opp-zaius.dtb: gpio@1e780000: 'line_bmc_i2c2_sw_rst_n', 'line_bmc_i2c5_sw_rst_n', 'line_iso_u146_en', 'ncsi_mux_en_n' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml# arch/arm/boot/dts/aspeed/aspeed-bmc-arm-stardragon4800-rep2.dtb: gpio@1e780000: 'pin_gpio_c7', 'pin_gpio_d1' do not match any of the regexes: '-hog(-[0-9]+)?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#