From: "Rob Herring (Arm)" <robh@kernel.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: netdev@vger.kernel.org, Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Dinh Nguyen <dinguyen@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
devicetree@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>
Subject: Re: [PATCH v4 2/6] dt-bindings: net: dwmac: Convert socfpga dwmac to DT schema
Date: Wed, 05 Feb 2025 10:49:45 -0600 [thread overview]
Message-ID: <173877418502.1694868.7734639778320336620.robh@kernel.org> (raw)
In-Reply-To: <20250205-v6-12-topic-socfpga-agilex5-v4-2-ebf070e2075f@pengutronix.de>
On Wed, 05 Feb 2025 16:32:23 +0100, Steffen Trumtrar wrote:
> Changes to the binding while converting:
> - add "snps,dwmac-3.7{0,2,4}a". They are used, but undocumented.
> - altr,f2h_ptp_ref_clk is not a required property but optional.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> .../bindings/net/pcs/altr,gmii-to-sgmii.yaml | 47 ++++++++++
> .../devicetree/bindings/net/socfpga-dwmac.txt | 57 ------------
> .../devicetree/bindings/net/socfpga-dwmac.yaml | 102 +++++++++++++++++++++
> 3 files changed, 149 insertions(+), 57 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/pcs/altr,gmii-to-sgmii.example.dtb: phy@100000240: reg: [[1, 576], [8, 1], [512, 64]] is too short
from schema $id: http://devicetree.org/schemas/pcs/altr,gmii-to-sgmii.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/pcs/altr,gmii-to-sgmii.example.dtb: phy@100000240: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pcs/altr,gmii-to-sgmii.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250205-v6-12-topic-socfpga-agilex5-v4-2-ebf070e2075f@pengutronix.de
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-02-05 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 15:32 [PATCH v4 0/6] ARM64: dts: intel: agilex5: add nodes and new board Steffen Trumtrar
2025-02-05 15:32 ` [PATCH v4 1/6] dt-bindings: socfpga-dwmac: fix typo Steffen Trumtrar
2025-02-10 10:19 ` Krzysztof Kozlowski
2025-02-05 15:32 ` [PATCH v4 2/6] dt-bindings: net: dwmac: Convert socfpga dwmac to DT schema Steffen Trumtrar
2025-02-05 16:49 ` Rob Herring (Arm) [this message]
2025-02-06 13:19 ` Steffen Trumtrar
2025-02-07 14:30 ` Rob Herring
2025-02-05 15:32 ` [PATCH v4 3/6] dt-bindings: net: dwmac: add compatible for Agilex5 Steffen Trumtrar
2025-02-10 10:23 ` Krzysztof Kozlowski
2025-02-05 15:32 ` [PATCH v4 4/6] arm64: dts: agilex5: add gmac nodes Steffen Trumtrar
2025-02-05 15:32 ` [PATCH v4 5/6] dt-bindings: intel: add agilex5-based Arrow AXE5-Eagle Steffen Trumtrar
2025-02-05 15:32 ` [PATCH v4 6/6] arm64: dts: agilex5: initial support for " Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173877418502.1694868.7734639778320336620.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®