From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jammy Huang <jammy_huang@aspeedtech.com>
Cc: linux-media@vger.kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzk+dt@kernel.org,
eajames@linux.ibm.com, mchehab@kernel.org, andrew@aj.id.au,
openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org,
linux-kernel@vger.kernel.org, joel@jms.id.au,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] media: dt-bindings: aspeed,video-engine: Convert to json schema
Date: Fri, 07 Feb 2025 03:25:25 -0600 [thread overview]
Message-ID: <173892032595.3714424.13095199531321692299.robh@kernel.org> (raw)
In-Reply-To: <20250207082351.1298990-1-jammy_huang@aspeedtech.com>
On Fri, 07 Feb 2025 16:23:51 +0800, Jammy Huang wrote:
> Convert aspeed-video.txt to yaml format.
> Update aspeed-video.txt to aspeed,video-engine.yaml in MAINTAINER file.
>
> Additional changes:
> - Two phandle properties, 'aspeed,scu' and 'aspeed,gfx', are added for
> video engine to capture video from sources other than VGA.
> - Update examples and include appropriate file directives to resolve
> errors identified by `dt_binding_check` and `dtbs_check`.
>
> Signed-off-by: Jammy Huang <jammy_huang@aspeedtech.com>
> ---
> v3:
> - Add Additional changes into comments.
> - Remove | after phandle description
>
> v2:
> - Update patch subject
> - Add NOTE for false positive warning
> ---
> .../bindings/media/aspeed,video-engine.yaml | 84 +++++++++++++++++++
> .../bindings/media/aspeed-video.txt | 33 --------
> MAINTAINERS | 2 +-
> 3 files changed, 85 insertions(+), 34 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/aspeed,video-engine.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/aspeed-video.txt
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/aspeed,video-engine.yaml:44:55: [error] syntax error: mapping values are not allowed here (syntax)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/aspeed,video-engine.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/media/aspeed,video-engine.yaml:44:55: mapping values are not allowed in this context
make[2]: *** Deleting file 'Documentation/devicetree/bindings/media/aspeed,video-engine.example.dts'
Documentation/devicetree/bindings/media/aspeed,video-engine.yaml:44:55: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/media/aspeed,video-engine.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207082351.1298990-1-jammy_huang@aspeedtech.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
prev parent reply other threads:[~2025-02-07 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 8:23 Jammy Huang
2025-02-07 9:25 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173892032595.3714424.13095199531321692299.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=jammy_huang@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®