From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: dhowells@redhat.com, Aaro Koskinen <aaro.koskinen@iki.fi>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org
Subject: Re: Bug report: unaligned access with ext4 encryption
Date: Fri, 04 Jan 2019 17:28:02 +0000 [thread overview]
Message-ID: <17391.1546622882@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190103171659.GA208343@gmail.com>
Eric Biggers <ebiggers@kernel.org> wrote:
> Hi Aaro, thanks for the bug report! I think you're on the right track; it makes
> much more sense to have the keyrings subsystem store the payload with better
> alignment, than to work around the 2-byte alignment in fscrypt.
>
> But how about '__aligned(__alignof__(u64))' instead? 4 bytes may not be enough.
>
> David, what do you think?
Does that even work?
Might be better to just insert 6 bytes of padding with a comment, but yes I
agree that it's probably better to align it to at least machine word size.
David
next prev parent reply other threads:[~2019-01-04 17:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 16:29 Aaro Koskinen
2019-01-03 17:17 ` Eric Biggers
2019-01-04 17:28 ` David Howells [this message]
2019-01-10 22:29 ` Aaro Koskinen
2019-01-10 23:01 ` Eric Biggers
2019-01-10 23:35 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17391.1546622882@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=aaro.koskinen@iki.fi \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome