From: Namhyung Kim <namhyung@kernel.org>
To: acme@kernel.org, irogers@google.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
kan.liang@linux.intel.com
Cc: peterz@infradead.org, mingo@redhat.com, thomas.falcon@intel.com
Subject: Re: [PATCH] perf tool_pmu: Add skip check in tool_pmu__event_to_str()
Date: Tue, 11 Feb 2025 17:39:01 -0800 [thread overview]
Message-ID: <173932434120.264355.5544623069913990027.b4-ty@kernel.org> (raw)
In-Reply-To: <20250207152844.302167-1-kan.liang@linux.intel.com>
On Fri, 07 Feb 2025 07:28:44 -0800, kan.liang@linux.intel.com wrote:
> Some topdown related metrics may fail on hybrid machines.
>
> $perf stat -M tma_frontend_bound
> Cannot resolve IDs for tma_frontend_bound:
> cpu_atom@TOPDOWN_FE_BOUND.ALL@ / (8 * cpu_atom@CPU_CLK_UNHALTED.CORE@)
>
> In the find_tool_events(), the tool_pmu__event_to_str() is used to
> compare the tool_events. It only checks the event name, no PMU or arch.
> So the tool_events[TOOL_PMU__EVENT_SLOTS] is set to true, because the
> p-core Topdown metrics has "slots" event.
> The tool_events is shared. So when parsing the e-core metrics, the
> "slots" is automatically added.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
prev parent reply other threads:[~2025-02-12 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 15:28 kan.liang
2025-02-07 16:52 ` Ian Rogers
2025-02-12 1:39 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173932434120.264355.5544623069913990027.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®