From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C31C24292F for ; Thu, 13 Feb 2025 18:17:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739470622; cv=none; b=i99FLkR5cLThAfF6zqMwoKeJVBEC+a9frT0rtGVA/E8/EGxpqq7yp0A4nvT0XSdHAF5aporieRXKXr6H2EiWxezMXyod9AY8hmCQ26QxxdfOHjf2Ym+bFB/o/EHKv5acwMuSBM2GIdg7SIyvpwEYJ8oVVcCzAQKb1A3Nuvupiv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739470622; c=relaxed/simple; bh=X0tuFPSSvJzxU+wZ2FKDaowZmVGUnx3nAlQffQt0rM8=; h=From:To:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=JPpuTb2S3n3XF7qIyRwIarbRxs1f9I6PSbNSOtMQsYzPhClH77gaazjGWNw1ZP0fyIxIeREJRAXKBOzs9nAFOZZlmweUfpD1xPa4fpEhdZKIboKRZSqB8CyAjG/rnBBswr6lUs60Tam4cEl1bvjgaVx1P9/Hv2cW32eWpLGDW/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iwMa+Q92; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iwMa+Q92" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD530C4CEE4; Thu, 13 Feb 2025 18:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739470622; bh=X0tuFPSSvJzxU+wZ2FKDaowZmVGUnx3nAlQffQt0rM8=; h=From:To:In-Reply-To:References:Subject:Date:From; b=iwMa+Q92QMTk7s31jZAyZg2gtnxmb2Y6zinOhcjqOtHE26bvHTU8Vn7aE4feGe53B 9ZvJ8pkFvXEaqDclLL0gmrqIIvOJWkOG2k5YqskYa/QX7RQ7xuGYBWpjChWuP/fX1a Gx+tndumEyTSE1gwq2Xj8PwhXUdNthD/U3s70tARLtA1t3MOP+ZX06r+pDfFfv27Sx k4pozEB0Ua5iWao8sv+dEagOwLeHTNBoA/IxUWbnhe9sKUDsT1LfMokJAPWNASme9o iL5RfK/AbWxzh4Mi9gfsB/JtP8VPnnb8ynCF48jYFTC985SU0yuAnrTVC4aYY8SFWi ryF57InQ/neBw== From: Vinod Koul To: Patrice Chotard , Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski In-Reply-To: <20250111185407.183855-1-krzysztof.kozlowski@linaro.org> References: <20250111185407.183855-1-krzysztof.kozlowski@linaro.org> Subject: Re: [PATCH] phy: stih407-usb: Use syscon_regmap_lookup_by_phandle_args Message-Id: <173947062030.294083.9746743441329264653.b4-ty@kernel.org> Date: Thu, 13 Feb 2025 23:47:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.2 On Sat, 11 Jan 2025 19:54:07 +0100, Krzysztof Kozlowski wrote: > Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over > syscon_regmap_lookup_by_phandle() combined with getting the syscon > argument. Except simpler code this annotates within one line that given > phandle has arguments, so grepping for code would be easier. > > There is also no real benefit in printing errors on missing syscon > argument, because this is done just too late: runtime check on > static/build-time data. Dtschema and Devicetree bindings offer the > static/build-time check for this already. > > [...] Applied, thanks! [1/1] phy: stih407-usb: Use syscon_regmap_lookup_by_phandle_args commit: 13c1eb1b4bd169f820188c62acaa1f96677284b1 Best regards, -- ~Vinod