From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C10A192D87; Wed, 19 Feb 2025 00:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739925746; cv=none; b=hjGvRhLr9dQbd8eiE7mcyvIyxkm90FZ9pYdLfAePxJYvUOWjKuDE8crPasEjiLGcI6+IVahYI6i1XSJznHAQv4EwfMzgKqFo4WbYpXj3vpCs97KeQ20Aut0rc3R8I7GtxDM+qYgNik87DjalP1eLWKIZsp7fHOAn2iF/hloVg04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739925746; c=relaxed/simple; bh=SFGHEtqDf6Y8YwEr7u4RWjuqbwl3vR2r58glzMk/aKA=; h=Date:Content-Type:MIME-Version:From:Cc:To:In-Reply-To:References: Message-Id:Subject; b=MOX4RVxWtWsTwuIjrJbSh4N7fdjptHx2/hJfF7pHH3jVZt6nZBD5ZHda4wVumxzeok2pQXzsJjcrz0kkzEeE0BMPnnaQc2tV8mmp3zu6+jpxLdjMjakr5VcLiE54oTKv9BMtsr4RFLqyOEJNgcqsogDaPB93JAUBg/N5zOpgShg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dkjSE2Sl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dkjSE2Sl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE4C8C4CEE6; Wed, 19 Feb 2025 00:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739925746; bh=SFGHEtqDf6Y8YwEr7u4RWjuqbwl3vR2r58glzMk/aKA=; h=Date:From:Cc:To:In-Reply-To:References:Subject:From; b=dkjSE2SlN6UY5t8f3DhnqLz3VLRWaWqki1iTcuLpI/8zz/8y9S3sbpwryWSd4Sndb Tu4x4D0FCfoi0ADQsixNVDSggUwySyeSartF4VpqywqfTjn+0qO5eS1VKIoHHtkNeP enR5EZT2BBDSQrz6cIx689BXFctPMxvLaJv+Ss2oKoLJ3PPh6xhzY4Hj7jfzPRwz2B QXnvIU41DQ+hXPERFVQCZbNboOoUTtZw3NqHHVutKOx556LfMjwprQ7H/IqVFtiIyC Q7q7yQr0VWYXErMwfz5E9NZbPgGaVqFJrnpfMMBas0NAGP9p1SFF/dQWmJviFpm7Jp 1/jEyHUQ+Zibg== Date: Tue, 18 Feb 2025 18:42:25 -0600 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: "Rob Herring (Arm)" Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Ivaylo Ivanov , Krzysztof Kozlowski , Conor Dooley , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Kees Cook , Krzysztof Kozlowski , Alim Akhtar To: Kaustabh Chakraborty In-Reply-To: <20250219-exynos7870-v3-0-e384fb610cad@disroot.org> References: <20250219-exynos7870-v3-0-e384fb610cad@disroot.org> Message-Id: <173992516637.2065489.12540018634541283812.robh@kernel.org> Subject: Re: [PATCH v3 0/7] Add support for the Exynos7870 SoC, along with three devices On Wed, 19 Feb 2025 00:33:10 +0530, Kaustabh Chakraborty wrote: > Samsung Exynos 7870 (codename: Joshua) is an ARM-v8 system-on-chip that was > announced in 2016. The chipset was found in several popular mid-range to > low-end Samsung phones, released within 2016 to 2019. > > This patch series aims to add support for Exynos 7870, starting with the > most basic yet essential components such as CPU, GPU, clock controllers, > PMIC, pin controllers, etc. > > Moreover, the series also adds support for three Exynos 7870 devices via > devicetree. The devices are: > * Samsung Galaxy J7 Prime - released 2016, codename on7xelte > * Samsung Galaxy J6 - released 2018, codename j6lte > * Samsung Galaxy A2 Core - released 2019, codename a2corelte > > Additional features implemented in this series include: > * I2C - touchscreen, IIO sensors, etc. > * UART - bluetooth and serial debugging > * MMC - eMMC, Wi-Fi SDIO, SDCard > * USB - micro-USB 2.0 interface > > Here is a list of all sub-series: > * bootmode - https://lore.kernel.org/all/20250204-exynos7870-bootmode-v1-1-0f17b3033c2d@disroot.org/ > * gpu R https://lore.kernel.org/all/20250204-exynos7870-gpu-v1-1-0db4c163a030@disroot.org/ > * i2c A https://lore.kernel.org/all/20250204-exynos7870-i2c-v1-0-63d67871ab7e@disroot.org/ > * mmc - https://lore.kernel.org/all/20250219-exynos7870-mmc-v2-0-b4255a3e39ed@disroot.org/ > * pinctrl - https://lore.kernel.org/all/20250219-exynos7870-pinctrl-v2-0-1ff9b10bf913@disroot.org/ > * pmic-regulators - https://lore.kernel.org/all/20250219-exynos7870-pmic-regulators-v2-0-1ea86fb332f7@disroot.org/ > * pmu-clocks - https://lore.kernel.org/all/20250219-exynos7870-pmu-clocks-v3-0-0d1e415e9e3a@disroot.org/ > * uart - https://lore.kernel.org/all/20250219-exynos7870-uart-v2-1-c8c67f3a936c@disroot.org/ > * usb - https://lore.kernel.org/all/20250219-exynos7870-usb-v2-0-1de41a89c9d4@disroot.org/ > * usbphy - https://lore.kernel.org/all/20250219-exynos7870-usbphy-v2-0-b8ba4e7a72e9@disroot.org/ > (Legend: [R]eviewed, [A]pplied) > > Signed-off-by: Kaustabh Chakraborty > --- > Changes in v3: > - Added patches from https://lore.kernel.org/all/20250204-exynos7870-chipid-v1-0-0bf2db08e621@disroot.org/ > - Fix devicetree formatting according to the devicetree style guide. > - Take over ownership of patches by the co-author, upon their request. > - Link to v2: https://lore.kernel.org/r/20250204-exynos7870-v2-0-56313165ef0c@disroot.org > > Changes in v2: > - Redo a few commit descriptions. > - Split patchsets into multiple sub-series, subsystem-wise. > - Link to v1: https://lore.kernel.org/r/20250203-exynos7870-v1-0-2b6df476a3f0@disroot.org > > --- > Kaustabh Chakraborty (7): > dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible > dt-bindings: arm: samsung: add compatibles for exynos7870 devices > soc: samsung: exynos-chipid: add support for exynos7870 > arm64: dts: exynos: add initial devicetree support for exynos7870 > arm64: dts: exynos: add initial support for Samsung Galaxy J7 Prime > arm64: dts: exynos: add initial support for Samsung Galaxy A2 Core > arm64: dts: exynos: add initial support for Samsung Galaxy J6 > > .../bindings/arm/samsung/samsung-boards.yaml | 8 + > .../bindings/hwinfo/samsung,exynos-chipid.yaml | 1 + > arch/arm64/boot/dts/exynos/Makefile | 3 + > .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 629 ++++++++++++ > arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts | 617 ++++++++++++ > arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 665 +++++++++++++ > arch/arm64/boot/dts/exynos/exynos7870-pinctrl.dtsi | 1022 ++++++++++++++++++++ > arch/arm64/boot/dts/exynos/exynos7870.dtsi | 720 ++++++++++++++ > drivers/soc/samsung/exynos-chipid.c | 1 + > 9 files changed, 3666 insertions(+) > --- > base-commit: e5d3fd687aac5eceb1721fa92b9f49afcf4c3717 > change-id: 20250201-exynos7870-049587e4b7df > > Best regards, > -- > Kaustabh Chakraborty > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250219-exynos7870-v3-0-e384fb610cad@disroot.org: In file included from arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts:10: arch/arm64/boot/dts/exynos/exynos7870.dtsi:9:10: fatal error: dt-bindings/clock/exynos7870.h: No such file or directory 9 | #include | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [scripts/Makefile.dtbs:131: arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb] Error 1 make[2]: *** [scripts/Makefile.build:461: arch/arm64/boot/dts/exynos] Error 2 make[2]: Target 'arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1459: exynos/exynos7870-on7xelte.dtb] Error 2 In file included from arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts:10: arch/arm64/boot/dts/exynos/exynos7870.dtsi:9:10: fatal error: dt-bindings/clock/exynos7870.h: No such file or directory 9 | #include | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [scripts/Makefile.dtbs:131: arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb] Error 1 make[2]: *** [scripts/Makefile.build:461: arch/arm64/boot/dts/exynos] Error 2 make[2]: Target 'arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1459: exynos/exynos7870-a2corelte.dtb] Error 2 In file included from arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts:10: arch/arm64/boot/dts/exynos/exynos7870.dtsi:9:10: fatal error: dt-bindings/clock/exynos7870.h: No such file or directory 9 | #include | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [scripts/Makefile.dtbs:131: arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb] Error 1 make[2]: *** [scripts/Makefile.build:461: arch/arm64/boot/dts/exynos] Error 2 make[2]: Target 'arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1459: exynos/exynos7870-j6lte.dtb] Error 2 make: *** [Makefile:251: __sub-make] Error 2 make: Target 'exynos/exynos8895-dreamlte.dtb' not remade because of errors. make: Target 'exynos/exynos850-e850-96.dtb' not remade because of errors. make: Target 'exynos/exynos7870-on7xelte.dtb' not remade because of errors. make: Target 'exynos/exynos7885-jackpotlte.dtb' not remade because of errors. make: Target 'exynos/exynos990-x1slte.dtb' not remade because of errors. make: Target 'exynos/exynos5433-tm2.dtb' not remade because of errors. make: Target 'exynos/exynos990-r8s.dtb' not remade because of errors. make: Target 'exynos/exynos7-espresso.dtb' not remade because of errors. make: Target 'exynos/google/gs101-oriole.dtb' not remade because of errors. make: Target 'exynos/google/gs101-raven.dtb' not remade because of errors. make: Target 'exynos/exynosautov920-sadk.dtb' not remade because of errors. make: Target 'exynos/exynosautov9-sadk.dtb' not remade because of errors. make: Target 'exynos/exynos990-c1s.dtb' not remade because of errors. make: Target 'exynos/exynos9810-starlte.dtb' not remade because of errors. make: Target 'exynos/exynos990-x1s.dtb' not remade because of errors. make: Target 'exynos/exynos7870-a2corelte.dtb' not remade because of errors. make: Target 'exynos/exynos5433-tm2e.dtb' not remade because of errors. make: Target 'exynos/exynos7870-j6lte.dtb' not remade because of errors.