From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: conor+dt@kernel.org, krzk+dt@kernel.org,
linux-mips@vger.kernel.org, tsbogend@alpha.franken.de,
andrew+netdev@lunn.ch, pabeni@redhat.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com,
lee@kernel.org, davem@davemloft.net
Subject: Re: [RESEND PATCH net-next 3/5] dt-bindings: net: Add Realtek MDIO controller
Date: Wed, 19 Feb 2025 08:06:36 -0600 [thread overview]
Message-ID: <173997391420.2383401.13425265155310657100.robh@kernel.org> (raw)
In-Reply-To: <20250218195216.1034220-4-chris.packham@alliedtelesis.co.nz>
On Wed, 19 Feb 2025 08:52:14 +1300, Chris Packham wrote:
> Add dtschema for the MDIO controller found in the RTL9300 Ethernet
> switch. The controller is slightly unusual in that direct MDIO
> communication is not possible. We model the MDIO controller with the
> MDIO buses as child nodes and the PHYs as children of the buses. The
> mapping of switch port number to MDIO bus/addr requires the
> ethernet-ports sibling to provide the mapping via the phy-handle
> property.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>
> Notes:
> This is technically v7 of [1] and [2] which are combined now that
> rtl9301-switch.yaml under net/ the only change from those is that the
> $ref: in rtl9301-switch.yaml can now use a relative path
>
> I could technically do away with the reg property on the mdio-controller
> node. I don't currently need to use it in my driver and it looks like
> the register offsets are the same between the RTL9300 and RTL9310.
>
> [1] - https://lore.kernel.org/lkml/20250204030249.1965444-6-chris.packham@alliedtelesis.co.nz/
> [2] - https://lore.kernel.org/lkml/20250204030249.1965444-4-chris.packham@alliedtelesis.co.nz/
>
> .../bindings/net/realtek,rtl9301-mdio.yaml | 86 +++++++++++++++++++
> .../bindings/net/realtek,rtl9301-switch.yaml | 31 +++++++
> 2 files changed, 117 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
Missing tags:
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2025-02-19 14:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 19:52 [RESEND PATCH net-next 0/5] dt-bindings: net: realtek,rtl9301-switch Chris Packham
2025-02-18 19:52 ` [RESEND PATCH net-next 1/5] dt-bindings: net: Move realtek,rtl9301-switch to net Chris Packham
2025-02-20 10:57 ` Lee Jones
2025-02-21 21:05 ` Rob Herring (Arm)
2025-02-18 19:52 ` [RESEND PATCH net-next 2/5] dt-bindings: net: Add switch ports and interrupts to RTL9300 Chris Packham
2025-02-21 21:06 ` Rob Herring (Arm)
2025-02-18 19:52 ` [RESEND PATCH net-next 3/5] dt-bindings: net: Add Realtek MDIO controller Chris Packham
2025-02-19 14:06 ` Rob Herring (Arm) [this message]
2025-02-19 20:42 ` Chris Packham
2025-02-18 19:52 ` [RESEND PATCH net-next 4/5] mips: dts: realtek: Add switch interrupts Chris Packham
2025-02-18 19:52 ` [RESEND PATCH net-next 5/5] mips: dts: cameo-rtl9302c: Add switch block Chris Packham
2025-02-21 23:30 ` [RESEND PATCH net-next 0/5] dt-bindings: net: realtek,rtl9301-switch patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173997391420.2383401.13425265155310657100.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®