From: Paulo Alcantara <pc@manguebit.org>
To: liuyong <pkfxxxing@gmail.com>, Namjae Jeon <linkinjeon@kernel.org>
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
security@kernel.org
Subject: Re: [PATCH 0/2] smb: client: validate ACL lengths and compare encoded SIDs
Date: Sun, 08 Nov 2026 15:32:14 -0300 [thread overview]
Message-ID: <173fb0ba5a3b968783dde74560d10bf9@manguebit.org> (raw)
In-Reply-To: <20261106104842.441067-1-pkfxxxing@gmail.com>
liuyong <pkfxxxing@gmail.com> writes:
> Hello,
>
> This series fixes two memory-safety issues in the CIFS/SMB3 client,
> reproduced on mainline commit f66469d9905b39d2c260a15d7d6db450f4db67c1:
>
> 1. A zero-length security-query response can bypass the caller's minimum
> and return ZERO_SIZE_PTR, causing an Oops during an ownership change.
> 2. populate_new_aces() compares variable-length SIDs over the maximum
> structure size, causing a KASAN out-of-bounds read during chmod.
> ...
Applied with MID_SID_LEN and MIN_SEC_DESC_LEN removed as there were left
unused after patch 1/2.
prev parent reply other threads:[~2026-11-08 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 10:48 liuyong
2026-11-06 10:48 ` [PATCH 1/2] smb: client: validate descriptor headers before query result allocation liuyong
2026-11-06 10:48 ` [PATCH 2/2] smb: client: compare owner and group SIDs using their encoded lengths liuyong
2026-11-06 13:07 ` [PATCH 0/2] smb: client: validate ACL lengths and compare encoded SIDs Namjae Jeon
2026-11-08 18:32 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173fb0ba5a3b968783dde74560d10bf9@manguebit.org \
--to=pc@manguebit.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pkfxxxing@gmail.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®