From: youquan_song@linux.intel.com
To: linux-kernel@vger.kernel.org
Cc: venkatesh.pallipadi@intel.com
Subject: [PATCH 2.6.26-rc3 : schedule] remove unlikely macros in workqueue.c/queue_delayed_work_on
Date: Thu, 29 May 2008 00:02:50 -0700 (PDT) [thread overview]
Message-ID: <1740.172.16.180.81.1212044570.squirrel@linux.intel.com> (raw)
cpufreq_ondemand governor call queue_delayed_work_on with entry parameter
"cpu" every sample rate(every logical cpu during 20ms).check the value of
"cpu","cpu>=0" condition meeting rate is over than 90%.
This patch remove the unlikely macros to benefit kernel schedule and
reader comprehension.
Signed-off-by: Youquan Song <youquan.song@intel.com>
---
workqueue.c | 2++++++
1 file changed, 1 insertions(+), 1 deletions(-)
--- linux-2.6/kernel/workqueue.c 2008-05-13 10:10:11.000000000 -0400
+++ linux-2.6-new/kernel/workqueue.c 2008-05-29 09:46:16.000000000 -0400
@@ -230,7 +230,7 @@
timer->data = (unsigned long)dwork;
timer->function = delayed_work_timer_fn;
- if (unlikely(cpu >= 0))
+ if (cpu >= 0)
add_timer_on(timer, cpu);
else
add_timer(timer);
next reply other threads:[~2008-05-29 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 7:02 youquan_song [this message]
2008-05-29 20:29 ` Andrew Morton
2008-05-29 22:50 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740.172.16.180.81.1212044570.squirrel@linux.intel.com \
--to=youquan_song@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®