From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>,
James Clark <james.clark@linaro.org>
Subject: Re: [PATCH 1/2] perf report: Switch data file correctly in TUI
Date: Thu, 20 Feb 2025 10:26:14 -0800 [thread overview]
Message-ID: <174007597411.1790567.6153686194745932876.b4-ty@kernel.org> (raw)
In-Reply-To: <20250211060745.294289-1-namhyung@kernel.org>
On Mon, 10 Feb 2025 22:07:44 -0800, Namhyung Kim wrote:
> The 's' key is to switch to a new data file and load the data in the
> same window. The switch_data_file() will show a popup menu to select
> which data file user wants and update the 'input_name' global variable.
>
> But in the cmd_report(), it didn't update the data.path using the new
> 'input_name' and keep usng the old file. This is fairly an old bug and
> I assume people don't use this feature much. :)
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
prev parent reply other threads:[~2025-02-20 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 6:07 Namhyung Kim
2025-02-11 6:07 ` [PATCH 2/2] perf report: Support switching data w/ and w/o callchains Namhyung Kim
2025-02-20 18:26 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174007597411.1790567.6153686194745932876.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dvyukov@google.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®