mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Wilson Ding <dingwei@marvell.com>
Cc: conor+dt@kernel.org, andrew@lunn.ch, krzk+dt@kernel.org,
	 linux-kernel@vger.kernel.org, gakula@marvell.com,
	 devicetree@vger.kernel.org, sebastian.hesselbarth@gmail.com,
	 p.zabel@pengutronix.de, salee@marvell.com,
	 linux-arm-kernel@lists.infradead.org,
	gregory.clement@bootlin.com
Subject: Re: [PATCH v2 1/4] dt-bindings: reset: Add Armada8K reset controller
Date: Thu, 20 Feb 2025 21:11:47 -0600	[thread overview]
Message-ID: <174010750791.4160970.11701879696918181174.robh@kernel.org> (raw)
In-Reply-To: <20250220232527.882888-2-dingwei@marvell.com>


On Thu, 20 Feb 2025 15:25:24 -0800, Wilson Ding wrote:
> Add device-tree binding documentation for the Armada8K reset driver.
> 
> Signed-off-by: Wilson Ding <dingwei@marvell.com>
> ---
>  .../reset/marvell,armada8k-reset.yaml         | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/marvell,armada8k-reset.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/reset/marvell,armada8k-reset.example.dts:22.46-26.15: Warning (unit_address_vs_reg): /example-0/system-controller@440000/reset-controller@268: node has a unit name, but no reg or ranges property
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reset/marvell,armada8k-reset.example.dtb: system-controller@440000: compatible: ['syscon', 'simple-mfd'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250220232527.882888-2-dingwei@marvell.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-02-21  3:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 23:25 [PATCH v2 0/4] Add Armada8K reset controller support Wilson Ding
2025-02-20 23:25 ` [PATCH v2 1/4] dt-bindings: reset: Add Armada8K reset controller Wilson Ding
2025-02-21  3:11   ` Rob Herring (Arm) [this message]
2025-02-21  8:46   ` Krzysztof Kozlowski
2025-02-21 23:40     ` Rob Herring
2025-02-22 20:57       ` Wilson Ding
2025-02-23  8:48         ` Krzysztof Kozlowski
2025-02-24 18:19           ` Wilson Ding
2025-02-20 23:25 ` [PATCH v2 2/4] dt-bindings: cp110: Document the " Wilson Ding
2025-02-21  8:46   ` Krzysztof Kozlowski
2025-02-22 21:02     ` [EXTERNAL] " Wilson Ding
2025-02-23  8:46       ` Krzysztof Kozlowski
2025-02-20 23:25 ` [PATCH v2 3/4] reset: Add support for Armada8K " Wilson Ding
2025-02-20 23:25 ` [PATCH v2 4/4] arm64: dts: marvell: cp11x: Add reset controller node Wilson Ding
2025-02-21  8:47   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174010750791.4160970.11701879696918181174.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dingwei@marvell.com \
    --cc=gakula@marvell.com \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=salee@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®