From: "Rob Herring (Arm)" <robh@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
linux-gpio@vger.kernel.org, linux-hardening@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kees Cook <kees@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-team@android.com,
Peter Griffin <peter.griffin@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding
Date: Mon, 24 Feb 2025 06:48:07 -0600 [thread overview]
Message-ID: <174040128694.2418814.685647591949303616.robh@kernel.org> (raw)
In-Reply-To: <20250224-max77759-mfd-v1-1-2bff36f9d055@linaro.org>
On Mon, 24 Feb 2025 10:28:49 +0000, André Draszik wrote:
> Add device tree binding for the Maxim MAX77759 companion PMIC for USB
> Type-C applications.
>
> The MAX77759 includes Battery Charger, Fuel Gauge, temperature sensors,
> USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander.
>
> This describes the core mfd device.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> .../devicetree/bindings/mfd/maxim,max77759.yaml | 104 +++++++++++++++++++++
> MAINTAINERS | 6 ++
> 2 files changed, 110 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: pmic@66: gpio: False schema does not allow {'compatible': ['maxim,max77759-gpio'], 'gpio-controller': True, '#gpio-cells': 2, 'interrupt-controller': True, '#interrupt-cells': 2}
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77759.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: pmic@66: pmic-nvmem: False schema does not allow {'compatible': ['maxim,max77759-nvmem'], 'nvmem-layout': {'compatible': ['fixed-layout'], '#address-cells': 1, '#size-cells': 1, 'reboot-mode@0': {'reg': [[0, 4]]}, 'boot-reason@4': {'reg': [[4, 4]]}, 'shutdown-user-flag@8': {'reg': [[8, 1]]}, 'rsoc@10': {'reg': [[10, 2]]}}}
from schema $id: http://devicetree.org/schemas/mfd/maxim,max77759.yaml#
Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: /example-0/i2c/pmic@66/gpio: failed to match any schema with compatible: ['maxim,max77759-gpio']
Documentation/devicetree/bindings/mfd/maxim,max77759.example.dtb: /example-0/i2c/pmic@66/pmic-nvmem: failed to match any schema with compatible: ['maxim,max77759-nvmem']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250224-max77759-mfd-v1-1-2bff36f9d055@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-02-24 12:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 10:28 [PATCH 0/6] Maxim Integrated MAX77759 PMIC MFD-based drivers André Draszik
2025-02-24 10:28 ` [PATCH 1/6] dt-bindings: mfd: add max77759 binding André Draszik
2025-02-24 12:48 ` Rob Herring (Arm) [this message]
2025-02-24 13:02 ` André Draszik
2025-02-24 13:05 ` Krzysztof Kozlowski
2025-02-24 13:07 ` Krzysztof Kozlowski
2025-02-24 13:14 ` André Draszik
2025-02-24 15:37 ` Rob Herring
2025-02-24 16:05 ` André Draszik
2025-02-26 17:56 ` André Draszik
2025-02-24 10:28 ` [PATCH 2/6] dt-bindings: gpio: " André Draszik
2025-02-24 15:38 ` Rob Herring
2025-02-24 21:52 ` André Draszik
2025-02-24 10:28 ` [PATCH 3/6] dt-bindings: nvmem: " André Draszik
2025-02-24 15:38 ` Rob Herring
2025-02-24 16:06 ` André Draszik
2025-02-24 10:28 ` [PATCH 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver André Draszik
2025-02-24 20:20 ` Christophe JAILLET
2025-02-24 21:32 ` André Draszik
2025-02-24 10:28 ` [PATCH 5/6] gpio: max77759: add Maxim MAX77759 gpio driver André Draszik
2025-02-24 10:46 ` André Draszik
2025-02-24 10:28 ` [PATCH 6/6] nvmem: max77759: add Maxim MAX77759 NVMEM driver André Draszik
2025-03-12 9:29 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174040128694.2418814.685647591949303616.robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®