From: "tip-bot2 for Brendan Jackman" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Brendan Jackman <jackmanb@google.com>,
Ingo Molnar <mingo@kernel.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/cpu] x86/cpu: Remove unnecessary macro indirection related to CPU feature names
Date: Tue, 04 Mar 2025 10:26:23 -0000 [thread overview]
Message-ID: <174108398359.14745.15032929904688026341.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250303-setcpuid-taint-louder-v1-1-8d255032cb4c@google.com>
The following commit has been merged into the x86/cpu branch of tip:
Commit-ID: 27c3b452c1a554483ac692702639c826602d1089
Gitweb: https://git.kernel.org/tip/27c3b452c1a554483ac692702639c826602d1089
Author: Brendan Jackman <jackmanb@google.com>
AuthorDate: Mon, 03 Mar 2025 15:45:37
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 04 Mar 2025 11:14:53 +01:00
x86/cpu: Remove unnecessary macro indirection related to CPU feature names
These macros used to abstract over CONFIG_X86_FEATURE_NAMES, but that
was removed in:
7583e8fbdc49 ("x86/cpu: Remove X86_FEATURE_NAMES")
Now they are just an unnecessary indirection, remove them.
Signed-off-by: Brendan Jackman <jackmanb@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20250303-setcpuid-taint-louder-v1-1-8d255032cb4c@google.com
---
arch/x86/include/asm/cpufeature.h | 5 -----
arch/x86/kernel/cpu/common.c | 12 ++++++------
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
index e5fc003..e955da3 100644
--- a/arch/x86/include/asm/cpufeature.h
+++ b/arch/x86/include/asm/cpufeature.h
@@ -37,13 +37,8 @@ enum cpuid_leafs
NR_CPUID_WORDS,
};
-#define X86_CAP_FMT_NUM "%d:%d"
-#define x86_cap_flag_num(flag) ((flag) >> 5), ((flag) & 31)
-
extern const char * const x86_cap_flags[NCAPINTS*32];
extern const char * const x86_power_flags[32];
-#define X86_CAP_FMT "%s"
-#define x86_cap_flag(flag) x86_cap_flags[flag]
/*
* In order to save room, we index into this array by doing
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 0f32b6f..b5fdaa6 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -667,8 +667,8 @@ static void filter_cpuid_features(struct cpuinfo_x86 *c, bool warn)
if (!warn)
continue;
- pr_warn("CPU: CPU feature " X86_CAP_FMT " disabled, no CPUID level 0x%x\n",
- x86_cap_flag(df->feature), df->level);
+ pr_warn("CPU: CPU feature %s disabled, no CPUID level 0x%x\n",
+ x86_cap_flags[df->feature], df->level);
}
}
@@ -1502,9 +1502,9 @@ static inline void parse_set_clear_cpuid(char *arg, bool set)
/* empty-string, i.e., ""-defined feature flags */
if (!x86_cap_flags[bit])
- pr_cont(" " X86_CAP_FMT_NUM, x86_cap_flag_num(bit));
+ pr_cont(" %d:%d", bit >> 5, bit & 31);
else
- pr_cont(" " X86_CAP_FMT, x86_cap_flag(bit));
+ pr_cont(" %s", x86_cap_flags[bit]);
if (set)
setup_force_cpu_cap(bit);
@@ -1523,9 +1523,9 @@ static inline void parse_set_clear_cpuid(char *arg, bool set)
const char *flag;
if (bit < 32 * NCAPINTS)
- flag = x86_cap_flag(bit);
+ flag = x86_cap_flags[bit];
else
- flag = x86_bug_flag(bit - (32 * NCAPINTS));
+ flag = x86_bug_flags[bit - (32 * NCAPINTS)];
if (!flag)
continue;
next prev parent reply other threads:[~2025-03-04 10:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 15:45 [PATCH 0/3] x86/cpu: Followups to adding setcpuid= Brendan Jackman
2025-03-03 15:45 ` [PATCH 1/3] x86/cpu: Remove some macros about feature names Brendan Jackman
2025-03-04 8:27 ` [tip: x86/cpu] x86/cpu: Remove unnecessary macro indirection related to CPU " tip-bot2 for Brendan Jackman
2025-03-04 10:26 ` tip-bot2 for Brendan Jackman [this message]
2025-03-03 15:45 ` [PATCH 2/3] x86/cpu: Warn louder about {set,clear}cpuid Brendan Jackman
2025-03-04 8:27 ` [tip: x86/cpu] x86/cpu: Warn louder about the {set,clear}cpuid boot parameters tip-bot2 for Brendan Jackman
2025-03-04 10:26 ` tip-bot2 for Brendan Jackman
2025-03-03 15:45 ` [PATCH 3/3] x86/cpu: Log CPU flag cmdline hacks more verbosely Brendan Jackman
2025-03-04 8:27 ` [tip: x86/cpu] " tip-bot2 for Brendan Jackman
2025-03-04 10:26 ` tip-bot2 for Brendan Jackman
2025-03-03 16:12 ` [PATCH 0/3] x86/cpu: Followups to adding setcpuid= Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174108398359.14745.15032929904688026341.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=bp@alien8.de \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®