From: "tip-bot2 for Uros Bizjak" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Uros Bizjak <ubizjak@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Brian Gerst <brgerst@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/asm] x86/irq/32: Use named operands in inline asm
Date: Tue, 04 Mar 2025 10:36:23 -0000 [thread overview]
Message-ID: <174108458356.14745.3836700447171821326.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250303155446.112769-1-ubizjak@gmail.com>
The following commit has been merged into the x86/asm branch of tip:
Commit-ID: df682f7b763e8d983ef70c4908f8980a2ffc81cd
Gitweb: https://git.kernel.org/tip/df682f7b763e8d983ef70c4908f8980a2ffc81cd
Author: Uros Bizjak <ubizjak@gmail.com>
AuthorDate: Mon, 03 Mar 2025 16:54:21 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 04 Mar 2025 11:21:40 +01:00
x86/irq/32: Use named operands in inline asm
Also use inout "+" constraint modifier where appropriate.
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250303155446.112769-1-ubizjak@gmail.com
---
arch/x86/kernel/irq_32.c | 20 +++++++++-----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c
index dc1049c..c4719c4 100644
--- a/arch/x86/kernel/irq_32.c
+++ b/arch/x86/kernel/irq_32.c
@@ -54,12 +54,11 @@ static inline void print_stack_overflow(void) { }
static void call_on_stack(void *func, void *stack)
{
- asm volatile("xchgl %%ebx,%%esp \n"
+ asm volatile("xchgl %[sp], %%esp\n"
CALL_NOSPEC
- "movl %%ebx,%%esp \n"
- : "=b" (stack)
- : "0" (stack),
- [thunk_target] "D"(func)
+ "movl %[sp], %%esp"
+ : [sp] "+b" (stack)
+ : [thunk_target] "D" (func)
: "memory", "cc", "edx", "ecx", "eax");
}
@@ -71,7 +70,7 @@ static inline void *current_stack(void)
static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
{
struct irq_stack *curstk, *irqstk;
- u32 *isp, *prev_esp, arg1;
+ u32 *isp, *prev_esp;
curstk = (struct irq_stack *) current_stack();
irqstk = __this_cpu_read(pcpu_hot.hardirq_stack_ptr);
@@ -94,12 +93,11 @@ static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
if (unlikely(overflow))
call_on_stack(print_stack_overflow, isp);
- asm volatile("xchgl %%ebx,%%esp \n"
+ asm volatile("xchgl %[sp], %%esp\n"
CALL_NOSPEC
- "movl %%ebx,%%esp \n"
- : "=a" (arg1), "=b" (isp)
- : "0" (desc), "1" (isp),
- [thunk_target] "D" (desc->handle_irq)
+ "movl %[sp], %%esp"
+ : "+a" (desc), [sp] "+b" (isp)
+ : [thunk_target] "D" (desc->handle_irq)
: "memory", "cc", "ecx");
return 1;
}
next prev parent reply other threads:[~2025-03-04 10:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 15:54 [PATCH -tip 1/5] " Uros Bizjak
2025-03-03 15:54 ` [PATCH -tip 2/5] x86/irq/32: Add missing clobber to " Uros Bizjak
2025-03-04 10:06 ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-03-04 10:36 ` tip-bot2 for Uros Bizjak
2025-03-04 19:23 ` tip-bot2 for Uros Bizjak
2025-03-03 15:54 ` [PATCH -tip 3/5] x86/irq/32: Add ASM_CALL_CONSTRAINT to inline asm using CALL_NOSPEC Uros Bizjak
2025-03-04 10:06 ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-03-04 10:36 ` tip-bot2 for Uros Bizjak
2025-03-04 19:23 ` tip-bot2 for Uros Bizjak
2025-03-03 15:54 ` [PATCH -tip 4/5] x86/irq/32: Use current_stack_pointer to avoid asm() in check_stack_overflow() Uros Bizjak
2025-03-04 10:06 ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-03-04 10:36 ` tip-bot2 for Uros Bizjak
2025-03-04 19:23 ` tip-bot2 for Uros Bizjak
2025-03-04 19:33 ` tip-bot2 for Uros Bizjak
2025-03-03 15:54 ` [PATCH -tip 5/5] x86/irq/32: Change some static functions to bool Uros Bizjak
2025-03-04 10:06 ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-03-04 10:36 ` tip-bot2 for Uros Bizjak
2025-03-04 19:23 ` tip-bot2 for Uros Bizjak
2025-03-04 19:33 ` tip-bot2 for Uros Bizjak
2025-03-04 10:06 ` [tip: x86/asm] x86/irq/32: Use named operands in inline asm tip-bot2 for Uros Bizjak
2025-03-04 10:36 ` tip-bot2 for Uros Bizjak [this message]
2025-03-04 19:23 ` tip-bot2 for Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174108458356.14745.3836700447171821326.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®