mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Artur Weber <aweber.kernel@gmail.com>
Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	Stanislav Jakubek <stano.jakubek@gmail.com>,
	Conor Dooley <conor+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	~postmarketos/upstreaming@lists.sr.ht,
	linux-arm-kernel@lists.infradead.org,
	Scott Branden <sbranden@broadcom.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: pinctrl: Add bindings for BCM21664 pin controller
Date: Tue, 4 Mar 2025 08:02:25 -0600	[thread overview]
Message-ID: <174109694544.2517876.17977367715126492989.robh@kernel.org> (raw)
In-Reply-To: <20250303-bcm21664-pinctrl-v3-1-5f8b80e4ab51@gmail.com>


On Mon, 03 Mar 2025 21:54:46 +0100, Artur Weber wrote:
> Add device tree bindings for the pin controller included in the
> BCM21664 chip. The bindings are based off brcm,bcm11351-pinctrl.yaml;
> both chips use the same driver, but have different pins, and the
> BCM21664 has 6 alt modes instead of 4.
> 
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
> Changes in v3:
> - Fix example for I2C pins
> - Specify bias-pull-up/bias-pull-down as a boolean
> - Add gpio16/gpio17 to list of I2C pins in slew-rate description
> - Use additionalProperties: false on pin group and specify valid
>   properties for more strict checking
> 
> Changes in v2:
> - Drop "property: true" declarations which had no effect with
>   "unevaluatedProperties: false"
> - Define property limits for I2C pins only instead of standard pins,
>   making the pin-specific "if" condition significantly smaller
> ---
>  .../bindings/pinctrl/brcm,bcm21664-pinctrl.yaml    | 152 +++++++++++++++++++++
>  1 file changed, 152 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


  reply	other threads:[~2025-03-04 14:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 20:54 [PATCH v3 0/6] pinctrl: bcm281xx: Add support for BCM21664 pinmux Artur Weber
2025-03-03 20:54 ` [PATCH v3 1/6] dt-bindings: pinctrl: Add bindings for BCM21664 pin controller Artur Weber
2025-03-04 14:02   ` Rob Herring (Arm) [this message]
2025-03-03 20:54 ` [PATCH v3 2/6] pinctrl: bcm281xx: Use "unsigned int" instead of bare "unsigned" Artur Weber
2025-03-03 20:54 ` [PATCH v3 3/6] pinctrl: bcm281xx: Provide pinctrl device info as OF platform data Artur Weber
2025-03-03 20:54 ` [PATCH v3 4/6] pinctrl: bcm281xx: Add support for BCM21664 pinmux Artur Weber
2025-03-03 20:54 ` [PATCH v3 5/6] ARM: dts: bcm2166x-common: Add pinctrl node Artur Weber
2025-03-06 18:21   ` Florian Fainelli
2025-03-03 20:54 ` [PATCH v3 6/6] ARM: dts: bcm2166x: Add bcm2166x-pinctrl DTSI Artur Weber
2025-03-06 18:21   ` Florian Fainelli
2025-03-05  8:04 ` [PATCH v3 0/6] pinctrl: bcm281xx: Add support for BCM21664 pinmux Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174109694544.2517876.17977367715126492989.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=aweber.kernel@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=krzk+dt@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stano.jakubek@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®