From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: YueHaibing <yuehaibing@huawei.com>
Cc: lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ACPI: SBS: remove unused variable 'SMBUS_PEC'
Date: Mon, 26 Aug 2019 11:08:59 +0200 [thread overview]
Message-ID: <174115399.5Pdya9bJQt@kreacher> (raw)
In-Reply-To: <20190822144346.12028-1-yuehaibing@huawei.com>
On Thursday, August 22, 2019 4:43:46 PM CEST YueHaibing wrote:
> drivers/acpi/sbshc.h:18:17: warning:
> SMBUS_PEC defined but not used [-Wunused-const-variable=]
>
> SMBUS_PEC is never used since introduction in
> commit 91087dfa51a2 ("ACPI: SBS: Split host
> controller (ACPI0001) from SBS driver (ACPI0002)"),
> so just remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/acpi/sbshc.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
> index 06372a3..c3522bb 100644
> --- a/drivers/acpi/sbshc.h
> +++ b/drivers/acpi/sbshc.h
> @@ -15,8 +15,6 @@ enum acpi_smb_protocol {
> SMBUS_BLOCK_PROCESS_CALL = 0xd,
> };
>
> -static const u8 SMBUS_PEC = 0x80;
> -
> enum acpi_sbs_device_addr {
> ACPI_SBS_CHARGER = 0x9,
> ACPI_SBS_MANAGER = 0xa,
>
Applied, thanks!
prev parent reply other threads:[~2019-08-26 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 14:43 YueHaibing
2019-08-26 9:08 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174115399.5Pdya9bJQt@kreacher \
--to=rjw@rjwysocki.net \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®