From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752708AbcIBInn (ORCPT ); Fri, 2 Sep 2016 04:43:43 -0400 Received: from zimbra13.linbit.com ([212.69.166.240]:38552 "EHLO zimbra13.linbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbcIBInm (ORCPT ); Fri, 2 Sep 2016 04:43:42 -0400 X-Greylist: delayed 1493 seconds by postgrey-1.27 at vger.kernel.org; Fri, 02 Sep 2016 04:43:41 EDT From: Philipp Reisner To: Baoyou Xie Cc: lars.ellenberg@linbit.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Subject: Re: [PATCH] drbd: mark symbols static where possible Date: Fri, 02 Sep 2016 10:18:35 +0200 Message-ID: <1741789.BtBaIYKiRQ@fat-tyre> User-Agent: KMail/5.2.3 (Linux/4.4.0-34-generic; KDE/5.25.0; x86_64; ; ) In-Reply-To: <1472727473-25593-1-git-send-email-baoyou.xie@linaro.org> References: <1472727473-25593-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baoyou, thanks for the patch. I applied it to our tree. Will be sent to one of the next merge windows... best regards, Phil Am Donnerstag, 1. September 2016, 18:57:53 CEST schrieb Baoyou Xie: > We get a few warnings when building kernel with W=1: > drivers/block/drbd/drbd_receiver.c:1224:6: warning: no previous prototype > for 'one_flush_endio' [-Wmissing-prototypes] > drivers/block/drbd/drbd_req.c:1450:6: warning: no previous prototype for > 'send_and_submit_pending' [-Wmissing-prototypes] > drivers/block/drbd/drbd_main.c:924:6: warning: no previous prototype for > 'assign_p_sizes_qlim' [-Wmissing-prototypes] .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/block/drbd/drbd_main.c | 4 +++- > drivers/block/drbd/drbd_receiver.c | 2 +- > drivers/block/drbd/drbd_req.c | 3 ++- > drivers/block/drbd/drbd_worker.c | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c > index 100be55..f0aa746 100644 > --- a/drivers/block/drbd/drbd_main.c > +++ b/drivers/block/drbd/drbd_main.c > @@ -921,7 +921,9 @@ void drbd_gen_and_send_sync_uuid(struct drbd_peer_device > *peer_device) } > > /* communicated if (agreed_features & DRBD_FF_WSAME) */ > -void assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p, > struct request_queue *q) +static void > +assign_p_sizes_qlim(struct drbd_device *device, struct p_sizes *p, > + struct request_queue *q) > { > if (q) { > p->qlim->physical_block_size = cpu_to_be32(queue_physical_block_size(q)); > diff --git a/drivers/block/drbd/drbd_receiver.c > b/drivers/block/drbd/drbd_receiver.c index 942384f..432f39a 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -1221,7 +1221,7 @@ struct one_flush_context { > struct issue_flush_context *ctx; > }; > > -void one_flush_endio(struct bio *bio) > +static void one_flush_endio(struct bio *bio) > { > struct one_flush_context *octx = bio->bi_private; > struct drbd_device *device = octx->device; > diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c > index de279fe..c725bf5 100644 > --- a/drivers/block/drbd/drbd_req.c > +++ b/drivers/block/drbd/drbd_req.c > @@ -1447,7 +1447,8 @@ static bool prepare_al_transaction_nonblock(struct > drbd_device *device, return !list_empty(pending); > } > > -void send_and_submit_pending(struct drbd_device *device, struct list_head > *pending) +static void > +send_and_submit_pending(struct drbd_device *device, struct list_head > *pending) { > struct drbd_request *req, *tmp; > > diff --git a/drivers/block/drbd/drbd_worker.c > b/drivers/block/drbd/drbd_worker.c index c6755c9..70f2706 100644 > --- a/drivers/block/drbd/drbd_worker.c > +++ b/drivers/block/drbd/drbd_worker.c > @@ -194,7 +194,8 @@ void drbd_peer_request_endio(struct bio *bio) > } > } > > -void drbd_panic_after_delayed_completion_of_aborted_request(struct > drbd_device *device) +static void > +drbd_panic_after_delayed_completion_of_aborted_request(struct drbd_device > *device) { > panic("drbd%u %s/%u potential random memory corruption caused by delayed > completion of aborted local request\n", device->minor, > device->resource->name, device->vnr);