Re: [PATCH v5 6/6] powercap: dtpm: Add RK3588 hierarchy

[Heiko Stuebner <heiko@sntech.de>]

Hi Daniel,

Am Dienstag, 3. November 2026, 05:48:20 Mitteleuropäische Normalzeit schrieb Daniel Lezcano:
> The RK3588 has three CPU frequency domains, with CPUs grouped into
> three cpufreq policies.
> 
> Add a DTPM hierarchy for the RK3588 with one CPU node per cpufreq
> policy, represented by cpu@0, cpu@400 and cpu@600. Group the three CPU
> domains under a virtual package node attached to the RK3588 root node.
> 
> Add the RK3588 compatible to the Rockchip DTPM match table to select
> the new hierarchy.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

[...]

>  static struct of_device_id __initdata rockchip_dtpm_match_table[] = {
>  	{ .compatible = "rockchip,rk3399", .data = &rk3399_hierarchy },
> +	{ .compatible = "rockchip,rk3588", .data = &rk3588_hierarchy },
>  	{},
>  };

the change itself looks good for the RK3588 (without variants), so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


but support for the family is sort of incomplete :-)
We have
- the rockchip,rk3588s (same as the rk3588 in terms of cores,
  but different compatible - see all the rk3588s-* boards)
- the RK3582 ... with a compatible of
  "rockchip,rk3582", "rockchip,rk3588s"
  Because this is some sort of chip with production defects
  where two _random_ big do not work or so and get disabled
  by firmware see [0] and marks them as "fail"

So as I said the change alone is fine, but there are additional variants
to maybe figure out in the future.


Heiko



[0] https://patchwork.ozlabs.org/project/uboot/cover/20250810222644.4095072-1-jonas@kwiboo.se/