mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: kuba@kernel.org, krzk+dt@kernel.org,
	linux-kernel@vger.kernel.org,  BMC-SW@aspeedtech.com,
	conor+dt@kernel.org, ratbert@faraday-tech.com,  joel@jms.id.au,
	andrew@codeconstruct.com.au, devicetree@vger.kernel.org,
	 pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org,
	 andrew+netdev@lunn.ch, linux-arm-kernel@lists.infradead.org,
	 linux-aspeed@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [net-next 3/4] dt-bindings: net: ftgmac100: add rgmii delay properties
Date: Sun, 16 Mar 2025 23:31:42 -0500	[thread overview]
Message-ID: <174218590293.2844402.7312672269180234107.robh@kernel.org> (raw)
In-Reply-To: <20250317025922.1526937-4-jacky_chou@aspeedtech.com>


On Mon, 17 Mar 2025 10:59:21 +0800, Jacky Chou wrote:
> Add tx-internal-delay-ps and rx-internal-delay-ps to
> configure the RGMII delay for MAC. According to
> ethernet-controller.yaml, they use for RGMII TX and RX delay.
> 
> In Aspeed desgin, the RGMII delay is a number of ps as unit to
> set delay, do not use one ps as unit. The values are different
> from each MAC. So, here describes the property values
> as index to configure corresponding scu register.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
>  .../bindings/net/faraday,ftgmac100.yaml          | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml:71:8: [warning] wrong indentation: expected 6 but found 7 (indentation)
./Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml:78:8: [warning] wrong indentation: expected 6 but found 7 (indentation)
./Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml:119:7: [error] no new line character at the end of file (new-line-at-end-of-file)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250317025922.1526937-4-jacky_chou@aspeedtech.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-03-17  4:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17  2:59 [net-next 0/4] Add AST2600 RGMII delay into ftgmac100 Jacky Chou
2025-03-17  2:59 ` [net-next 1/4] ARM: dts: aspeed-g6:add scu to mac for RGMII delay Jacky Chou
2025-03-17 12:47   ` Andrew Lunn
2025-03-18 11:44     ` 回覆: " Jacky Chou
2025-03-17  2:59 ` [net-next 2/4] ARM: dts: ast2600-evb: add default " Jacky Chou
2025-03-17 13:08   ` Andrew Lunn
2025-03-18 11:00     ` 回覆: " Jacky Chou
2025-03-18 14:03       ` Andrew Lunn
2025-03-20  8:02         ` 回覆: " Jacky Chou
2025-03-17  2:59 ` [net-next 3/4] dt-bindings: net: ftgmac100: add rgmii delay properties Jacky Chou
2025-03-17  4:31   ` Rob Herring (Arm) [this message]
2025-03-17  7:32   ` Krzysztof Kozlowski
2025-03-17  7:48     ` 回覆: " Jacky Chou
2025-03-17 12:44   ` Andrew Lunn
2025-03-17 13:21     ` Krzysztof Kozlowski
2025-03-17  2:59 ` [net-next 4/4] net: ftgmac100: add RGMII delay for AST2600 Jacky Chou
2025-03-17  8:53   ` Maxime Chevallier
2025-03-17  9:28     ` 回覆: " Jacky Chou
2025-03-17 11:09     ` Russell King (Oracle)
2025-03-17 11:33       ` 回覆: " Jacky Chou
2025-03-17 12:52         ` Andrew Lunn
2025-03-18  5:34           ` 回覆: " Jacky Chou
2025-03-18 13:51             ` Andrew Lunn
2025-03-18 16:38               ` Krzysztof Kozlowski
2025-03-20  8:06                 ` 回覆: " Jacky Chou
2025-03-17 13:03   ` Andrew Lunn
2025-03-18 10:46     ` 回覆: " Jacky Chou
2025-03-18 13:44       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174218590293.2844402.7312672269180234107.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=BMC-SW@aspeedtech.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=jacky_chou@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ratbert@faraday-tech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®