From: "tip-bot2 for Namhyung Kim" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Matteo Rizzo <matteorizzo@google.com>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/urgent] perf/x86: Check data address for IBS software filter
Date: Mon, 17 Mar 2025 09:15:05 -0000 [thread overview]
Message-ID: <174220290574.14745.9132867025462242568.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250317081058.1794729-1-namhyung@kernel.org>
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: b0be17d8108bf3448a58be319d085155a128cf3a
Gitweb: https://git.kernel.org/tip/b0be17d8108bf3448a58be319d085155a128cf3a
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Mon, 17 Mar 2025 01:10:58 -07:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Mon, 17 Mar 2025 10:04:31 +01:00
perf/x86: Check data address for IBS software filter
The IBS software filter is filtering kernel samples for regular users in
PMI handler. It checks the instruction address in the IBS register to
determine if it was in the kernel mode or not.
But it turns out that it's possible to report a kernel data address even
if the instruction address belongs to the user space. Matteo Rizzo
found that when an instruction raises an exception, IBS can report some
kernel data address like IDT while holding the faulting instruction's
RIP. To prevent an information leak, it should double check if the data
address in PERF_SAMPLE_DATA is in the kernel space as well.
Suggested-by: Matteo Rizzo <matteorizzo@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250317081058.1794729-1-namhyung@kernel.org
---
arch/x86/events/amd/ibs.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c
index e7a8b87..24985c7 100644
--- a/arch/x86/events/amd/ibs.c
+++ b/arch/x86/events/amd/ibs.c
@@ -1147,6 +1147,13 @@ fail:
if (perf_ibs == &perf_ibs_op)
perf_ibs_parse_ld_st_data(event->attr.sample_type, &ibs_data, &data);
+ if ((event->attr.config2 & IBS_SW_FILTER_MASK) &&
+ (event->attr.sample_type & PERF_SAMPLE_ADDR) &&
+ event->attr.exclude_kernel && !access_ok(data.addr)) {
+ throttle = perf_event_account_interrupt(event);
+ goto out;
+ }
+
/*
* rip recorded by IbsOpRip will not be consistent with rsp and rbp
* recorded as part of interrupt regs. Thus we need to use rip from
next prev parent reply other threads:[~2025-03-17 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 8:10 [PATCH] " Namhyung Kim
2025-03-17 9:15 ` tip-bot2 for Namhyung Kim [this message]
2025-03-17 10:10 ` [tip: perf/urgent] " Borislav Petkov
2025-03-17 15:57 ` Namhyung Kim
2025-03-17 10:15 ` Peter Zijlstra
2025-03-17 16:01 ` Namhyung Kim
2025-03-17 13:29 ` [PATCH] " Ravi Bangoria
2025-03-17 16:02 ` Namhyung Kim
2025-03-17 16:23 ` Namhyung Kim
2025-03-17 16:37 [PATCH v2] " Namhyung Kim
2025-03-17 22:51 ` [tip: perf/urgent] " tip-bot2 for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174220290574.14745.9132867025462242568.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=matteorizzo@google.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®