From: "Rob Herring (Arm)" <robh@kernel.org>
To: Matthew Gerlach <matthew.gerlach@altera.com>
Cc: mchehab@kernel.org, linux-edac@vger.kernel.org,
tony.luck@intel.com, conor+dt@kernel.org, krzk+dt@kernel.org,
linux-kernel@vger.kernel.org, james.morse@arm.com,
rric@kernel.org, dinguyen@kernel.org, bp@alien8.de,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/4] dt-bindings: edac: altera-s10: Convert to YAML
Date: Thu, 20 Mar 2025 13:26:14 -0500 [thread overview]
Message-ID: <174249492093.658105.12153092759643432322.robh@kernel.org> (raw)
In-Reply-To: <20250320164622.6971-1-matthew.gerlach@altera.com>
On Thu, 20 Mar 2025 09:46:18 -0700, Matthew Gerlach wrote:
> This patch set creates a YAML device tree binding for the Altera Stratix10
> Error Detection and Correction component referred to as the ECC Manager. The
> peripheral subcomponents are the same hardware as the Arria10 implementation;
> so the YAML binding does not change compatible strings of the subcomponents.
> This more accurate hardware description requires some minor driver and DTSI/DTS
> changes.
>
> Patch 1:
> Convert text device tree binding to YAML.
>
> Patch 2:
> Update driver to allow the peripheral subcomponents to be child nodes of
> altr,socfpga-s10-ecc-manager.
>
> Patch 3:
> Update Agilex DTSI to use correct compatible strings for peripheral
> subcomponents.
>
> Patch 4:
> Update Stratix10 DTSI/DTS to use correct compatibles strings.
>
> Matthew Gerlach (4):
> dt-bindings: edac: altera-s10: Convert to YAML
> EDAC, altera: update driver to reflect hw/yaml
> arm64: dts: agilex: Update eccmgr in DTSI to reflect hw/yaml
> arm64: dts: startix10: Update eccmgr in DTSI/DTS to reflect hw/yaml
>
> .../edac/altr,socfpga-s10-ecc-manager.yaml | 228 ++++++++++++++++++
> .../bindings/edac/socfpga-eccmgr.txt | 150 ------------
> MAINTAINERS | 5 +
> .../boot/dts/altera/socfpga_stratix10.dtsi | 15 +-
> .../dts/altera/socfpga_stratix10_socdk.dts | 3 +-
> arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 18 +-
> drivers/edac/altera_edac.c | 3 +
> 7 files changed, 248 insertions(+), 174 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/edac/altr,socfpga-s10-ecc-manager.yaml
>
> --
> 2.35.3
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/altera/' for 20250320164622.6971-1-matthew.gerlach@altera.com:
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dtb: eccmgr: sdmmca-ecc@ff8c8c00:compatible:0: 'altr,socfpga-sdmmc-ecc' was expected
from schema $id: http://devicetree.org/schemas/altr,socfpga-s10-ecc-manager.yaml#
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dtb: eccmgr: sdmmca-ecc@ff8c8c00:compatible: ['altr,socfpga-s10-sdmmc-ecc', 'altr,socfpga-sdmmc-ecc'] is too long
from schema $id: http://devicetree.org/schemas/altr,socfpga-s10-ecc-manager.yaml#
prev parent reply other threads:[~2025-03-20 18:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 16:46 Matthew Gerlach
2025-03-20 16:46 ` [PATCH 1/4] " Matthew Gerlach
2025-03-20 19:27 ` Rob Herring
2025-03-20 23:18 ` Gerlach, Matthew
2025-03-20 16:46 ` [PATCH 2/4] EDAC, altera: update driver to reflect hw/yaml Matthew Gerlach
2025-03-21 21:12 ` Borislav Petkov
2025-03-23 16:13 ` Gerlach, Matthew
2025-03-20 16:46 ` [PATCH 3/4] arm64: dts: agilex: Update eccmgr in DTSI " Matthew Gerlach
2025-03-20 19:34 ` Rob Herring
2025-03-20 23:24 ` Gerlach, Matthew
2025-03-21 7:46 ` Krzysztof Kozlowski
2025-03-20 16:46 ` [PATCH 4/4] arm64: dts: startix10: Update eccmgr in DTSI/DTS " Matthew Gerlach
2025-03-20 18:26 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174249492093.658105.12153092759643432322.robh@kernel.org \
--to=robh@kernel.org \
--cc=bp@alien8.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=james.morse@arm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@altera.com \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®