From: "Rob Herring (Arm)" <robh@kernel.org>
To: Artur Rojek <artur@conclusive.pl>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, Jakub Klama <jakub@conclusive.pl>,
Johannes Berg <johannes@sipsolutions.net>,
Wojciech Kloska <wojciech@conclusive.pl>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Ulf Axelsson <ulf.axelsson@nordicsemi.no>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] dt-bindings: wireless: Document Nordic nRF70 bindings
Date: Mon, 24 Mar 2025 18:05:13 -0500 [thread overview]
Message-ID: <174285751372.1003267.5777705239972389695.robh@kernel.org> (raw)
In-Reply-To: <20250324211045.3508952-3-artur@conclusive.pl>
On Mon, 24 Mar 2025 22:10:45 +0100, Artur Rojek wrote:
> Add a documentation file to describe the Device Tree bindings for the
> Nordic Semiconductor nRF70 series wireless companion IC.
>
> Signed-off-by: Artur Rojek <artur@conclusive.pl>
> ---
> .../bindings/net/wireless/nordic,nrf70.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/wireless/nordic,nrf70.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/nordic,nrf70.yaml: properties:compatible: 'anyOf' conditional failed, one must be fixed:
'req' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/nordic,nrf70.yaml: 'oneOf' conditional failed, one must be fixed:
'unevaluatedProperties' is a required property
'additionalProperties' is a required property
hint: Either unevaluatedProperties or additionalProperties must be present
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/nordic,nrf70.yaml: properties:compatible: Additional properties are not allowed ('req' was unexpected)
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250324211045.3508952-3-artur@conclusive.pl
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
prev parent reply other threads:[~2025-03-24 23:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 21:10 [RFC PATCH 0/2] Nordic nRF70 series Artur Rojek
2025-03-24 21:10 ` [RFC PATCH 1/2] net: wireless: Add Nordic nRF70 series Wi-Fi driver Artur Rojek
2025-04-01 14:11 ` Sascha Hauer
2025-04-18 12:46 ` Artur Rojek
2025-04-24 13:16 ` Sascha Hauer
2025-04-29 5:04 ` Eric Biggers
2025-03-24 21:10 ` [RFC PATCH 2/2] dt-bindings: wireless: Document Nordic nRF70 bindings Artur Rojek
2025-03-24 23:05 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174285751372.1003267.5777705239972389695.robh@kernel.org \
--to=robh@kernel.org \
--cc=artur@conclusive.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jakub@conclusive.pl \
--cc=johannes@sipsolutions.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ulf.axelsson@nordicsemi.no \
--cc=wojciech@conclusive.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®