From: "Rob Herring (Arm)" <robh@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH 0/5] arm64: dts: rockchip: add ROCK 5B+ support
Date: Mon, 24 Mar 2025 22:13:21 -0500 [thread overview]
Message-ID: <174287236051.1618248.4100886448951731382.robh@kernel.org> (raw)
In-Reply-To: <20250324-rock5bp-for-upstream-v1-0-6217edf15b19@kernel.org>
On Mon, 24 Mar 2025 18:04:21 +0100, Sebastian Reichel wrote:
> This series adds support for the ROCK 5B+, which (as the name suggests)
> is an improved version of the ROCK 5B. It also adds initial USB-C
> support for both the ROCK 5B and the 5B+.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> Sebastian Reichel (5):
> arm64: dts: rockchip: move rock 5b to include file
> arm64: dts: rockchip: move rock 5b to include file
> dt-bindings: arm: rockchip: Add Radxa ROCK 5B+
> arm64: dts: rockchip: add Rock 5B+
> arm64: dts: rockchip: add USB-C support for ROCK 5B and 5B+
>
> .../devicetree/bindings/arm/rockchip.yaml | 5 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3588-rock-5b-plus.dts | 117 +++
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 952 +----------------
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi | 1087 ++++++++++++++++++++
> 5 files changed, 1220 insertions(+), 942 deletions(-)
> ---
> base-commit: 76728fe54f547950f73c9dc446beb2e31604abd7
> change-id: 20250324-rock5bp-for-upstream-fd85b00b593b
>
> Best regards,
> --
> Sebastian Reichel <sre@kernel.org>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250324-rock5bp-for-upstream-v1-0-6217edf15b19@kernel.org:
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: power-controller: power-domain@12: Unevaluated properties are not allowed ('domain-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/power/rockchip,power-controller.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: vop@fdd90000: clocks: [[33, 605], [33, 604], [33, 609], [33, 610], [33, 611], [33, 612], [33, 603], [107], [108]] is too long
from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: vop@fdd90000: clock-names: ['aclk', 'hclk', 'dclk_vp0', 'dclk_vp1', 'dclk_vp2', 'dclk_vp3', 'pclk_vop', 'pll_hdmiphy0', 'pll_hdmiphy1'] is too long
from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: spdif-tx@fddb0000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /spdif-tx@fddb0000: failed to match any schema with compatible: ['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: spdif-tx@fdde0000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /spdif-tx@fdde0000: failed to match any schema with compatible: ['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /rng@fe378000: failed to match any schema with compatible: ['rockchip,rk3588-rng']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: spdif-tx@fe4e0000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /spdif-tx@fe4e0000: failed to match any schema with compatible: ['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: spdif-tx@fe4f0000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /spdif-tx@fe4f0000: failed to match any schema with compatible: ['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: spdif-tx@fddb8000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /spdif-tx@fddb8000: failed to match any schema with compatible: ['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: spdif-tx@fdde8000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif'] is too long
'rockchip,rk3066-spdif' was expected
'rockchip,rk3228-spdif' was expected
'rockchip,rk3328-spdif' was expected
'rockchip,rk3366-spdif' was expected
'rockchip,rk3368-spdif' was expected
'rockchip,rk3399-spdif' was expected
'rockchip,rk3568-spdif' was expected
'rockchip,rk3588-spdif' is not one of ['rockchip,rk3128-spdif', 'rockchip,rk3188-spdif', 'rockchip,rk3288-spdif', 'rockchip,rk3308-spdif']
from schema $id: http://devicetree.org/schemas/sound/rockchip-spdif.yaml#
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /spdif-tx@fdde8000: failed to match any schema with compatible: ['rockchip,rk3588-spdif', 'rockchip,rk3568-spdif']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /hdmi_receiver@fdee0000: failed to match any schema with compatible: ['rockchip,rk3588-hdmirx-ctrler', 'snps,dw-hdmi-rx']
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb: vop@fdd90000: clocks: [[33, 605], [33, 604], [33, 609], [33, 610], [33, 611], [33, 612], [33, 603], [107], [108]] is too long
from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml#
prev parent reply other threads:[~2025-03-25 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 17:04 Sebastian Reichel
2025-03-24 17:04 ` [PATCH 1/5] arm64: dts: rockchip: move rock 5b to include file Sebastian Reichel
2025-03-24 17:04 ` [PATCH 2/5] " Sebastian Reichel
2025-05-08 14:46 ` Nicolas Frattaroli
2025-03-24 17:04 ` [PATCH 3/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5B+ Sebastian Reichel
2025-03-25 2:49 ` Rob Herring
2025-03-24 17:04 ` [PATCH 4/5] arm64: dts: rockchip: add Rock 5B+ Sebastian Reichel
2025-03-24 17:04 ` [PATCH 5/5] arm64: dts: rockchip: add USB-C support for ROCK 5B and 5B+ Sebastian Reichel
2025-03-25 3:13 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174287236051.1618248.4100886448951731382.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®