From: "Rob Herring (Arm)" <robh@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: conor+dt@kernel.org, lgirdwood@gmail.com,
linux-usb@vger.kernel.org, mka@chromium.org,
linux-kernel@vger.kernel.org, stern@rowland.harvard.edu,
festevam@gmail.com, broonie@kernel.org, kernel@pengutronix.de,
krzk+dt@kernel.org, festevam@denx.de,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 3/4] dt-bindings: usb: microchip,usb2514: add support for port vbus-supply
Date: Thu, 27 Mar 2025 13:54:32 -0500 [thread overview]
Message-ID: <174310167224.833960.653017791858218794.robh@kernel.org> (raw)
In-Reply-To: <20250327172803.3404615-4-m.felsch@pengutronix.de>
On Thu, 27 Mar 2025 18:28:02 +0100, Marco Felsch wrote:
> Some PCB designs don't connect the USB hub port power control GPIO and
> instead make use of a host controllable regulator. Add support for this
> use-case by introducing portX-vbus-supply property.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> .../devicetree/bindings/usb/microchip,usb2514.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/usb/microchip,usb2514.yaml:53:5: [error] syntax error: could not find expected ':' (syntax)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/usb/microchip,usb2514.yaml:53:5: could not find expected ':'
make[2]: *** Deleting file 'Documentation/devicetree/bindings/usb/microchip,usb2514.example.dts'
Documentation/devicetree/bindings/usb/microchip,usb2514.yaml:53:5: could not find expected ':'
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/usb/microchip,usb2514.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1522: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250327172803.3404615-4-m.felsch@pengutronix.de
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-27 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 17:27 [PATCH v2 0/4] Add ext. port vbus handling for onboard-dev Marco Felsch
2025-03-27 17:28 ` [PATCH v2 1/4] usb: port: track the disabled state Marco Felsch
2025-03-27 17:28 ` [PATCH v2 2/4] usb: hub: add infrastructure to pass onboard_dev port features Marco Felsch
2025-03-27 17:28 ` [PATCH v2 3/4] dt-bindings: usb: microchip,usb2514: add support for port vbus-supply Marco Felsch
2025-03-27 18:54 ` Rob Herring (Arm) [this message]
2025-03-27 17:28 ` [PATCH v2 4/4] usb: misc: onboard_dev: add ext-vbus-supply handling Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174310167224.833960.653017791858218794.robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mka@chromium.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®