From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: hmh@hmh.eng.br, hdegoede@redhat.com,
Seyediman Seyedarab <imandevel@gmail.com>
Cc: ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Seyediman Seyedarab <ImanDevel@gmail.com>,
Vlastimil Holer <vlastimil.holer@gmail.com>,
stable@vger.kernel.org,
Alireza Elikahi <scr0lll0ck1s4b0v3h0m3k3y@gmail.com>,
Kurt Borja <kuurtb@gmail.com>,
Eduard Christian Dumitrescu <eduard.c.dumitrescu@gmail.com>
Subject: Re: [PATCH v3] platform/x86: thinkpad_acpi: disable ACPI fan access for T495* and E560
Date: Tue, 01 Apr 2025 14:35:19 +0300 [thread overview]
Message-ID: <174350731915.2494.4458891330469738526.b4-ty@linux.intel.com> (raw)
In-Reply-To: <20250324152442.106113-1-ImanDevel@gmail.com>
On Mon, 24 Mar 2025 11:24:42 -0400, Seyediman Seyedarab wrote:
> T495, T495s, and E560 laptops have the FANG+FANW ACPI methods (therefore
> fang_handle and fanw_handle are not NULL) but they do not actually work,
> which results in a "No such device or address" error. The DSDT table code
> for the FANG+FANW methods doesn't seem to do anything special regarding
> the fan being secondary. Fan access and control is restored after forcing
> the legacy non-ACPI fan control method by setting both fang_handle and
> fanw_handle to NULL. The bug was introduced in commit 57d0557dfa49
> ("platform/x86: thinkpad_acpi: Add Thinkpad Edge E531 fan support"),
> which added a new fan control method via the FANG+FANW ACPI methods.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: thinkpad_acpi: disable ACPI fan access for T495* and E560
commit: 2b9f84e7dc863afd63357b867cea246aeedda036
--
i.
prev parent reply other threads:[~2025-04-01 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 15:24 Seyediman Seyedarab
2025-03-31 14:30 ` Seyediman Seyedarab
2025-04-01 11:35 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174350731915.2494.4458891330469738526.b4-ty@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=eduard.c.dumitrescu@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=imandevel@gmail.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=scr0lll0ck1s4b0v3h0m3k3y@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vlastimil.holer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®