mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Baoquan He" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Baoquan He <bhe@redhat.com>, Ingo Molnar <mingo@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: x86/mm] x86/mm: Simplify the pgd_leaf() and p4d_leaf() checks a bit
Date: Tue, 01 Apr 2025 21:03:46 -0000	[thread overview]
Message-ID: <174354142637.14745.6334396639863551404.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20250331081327.256412-6-bhe@redhat.com>

The following commit has been merged into the x86/mm branch of tip:

Commit-ID:     2b00d9031e42eabc8d32847d231ef48b8be0373d
Gitweb:        https://git.kernel.org/tip/2b00d9031e42eabc8d32847d231ef48b8be0373d
Author:        Baoquan He <bhe@redhat.com>
AuthorDate:    Mon, 31 Mar 2025 16:13:25 +08:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 01 Apr 2025 22:48:56 +02:00

x86/mm: Simplify the pgd_leaf() and p4d_leaf() checks a bit

The functions return bool, simplify the checks.

[ mingo: Split off from two other patches. ]

Signed-off-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20250331081327.256412-6-bhe@redhat.com
---
 arch/x86/mm/pti.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c
index 5f0d579..1902998 100644
--- a/arch/x86/mm/pti.c
+++ b/arch/x86/mm/pti.c
@@ -185,7 +185,7 @@ static p4d_t *pti_user_pagetable_walk_p4d(unsigned long address)
 
 		set_pgd(pgd, __pgd(_KERNPG_TABLE | __pa(new_p4d_page)));
 	}
-	BUILD_BUG_ON(pgd_leaf(*pgd) != 0);
+	BUILD_BUG_ON(pgd_leaf(*pgd));
 
 	return p4d_offset(pgd, address);
 }
@@ -206,7 +206,7 @@ static pmd_t *pti_user_pagetable_walk_pmd(unsigned long address)
 	if (!p4d)
 		return NULL;
 
-	BUILD_BUG_ON(p4d_leaf(*p4d) != 0);
+	BUILD_BUG_ON(p4d_leaf(*p4d));
 	if (p4d_none(*p4d)) {
 		unsigned long new_pud_page = __get_free_page(gfp);
 		if (WARN_ON_ONCE(!new_pud_page))

  parent reply	other threads:[~2025-04-01 21:03 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31  8:13 [PATCH v2 0/7] mm/gup: Minor fix, cleanup and improvements Baoquan He
2025-03-31  8:13 ` [PATCH v2 1/7] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() Baoquan He
2025-04-01  8:10   ` David Hildenbrand
2025-04-01 14:00     ` Oscar Salvador
2025-04-01 14:12       ` Baoquan He
2025-04-01 14:11     ` Baoquan He
2025-03-31  8:13 ` [PATCH v2 2/7] mm/gup: check if both GUP_GET and GUP_PIN are set in __get_user_pages() earlier Baoquan He
2025-04-01  8:02   ` David Hildenbrand
2025-04-01 14:34     ` Baoquan He
2025-04-01 14:37       ` David Hildenbrand
2025-04-02  1:26         ` Baoquan He
2025-03-31  8:13 ` [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked() Baoquan He
2025-04-01  8:14   ` David Hildenbrand
2025-04-01 14:36     ` Baoquan He
2025-04-01 13:51   ` Oscar Salvador
2025-04-01 15:29     ` Baoquan He
2025-03-31  8:13 ` [PATCH v2 4/7] mm/gup: remove gup_fast_pgd_leaf() and clean up the relevant codes Baoquan He
2025-04-01  8:19   ` David Hildenbrand
2025-04-01 14:11   ` Oscar Salvador
2025-03-31  8:13 ` [PATCH v2 5/7] x86/mm: remove pgd_leaf definition in arch Baoquan He
2025-03-31 10:25   ` [tip: x86/mm] x86/mm: Simplify the pgd_leaf() and p4d_leaf() checks a bit tip-bot2 for Baoquan He
2025-03-31 10:26   ` [tip: x86/mm] x86/mm: Remove the arch-specific pgd_leaf() definition tip-bot2 for Baoquan He
2025-04-01  8:21   ` [PATCH v2 5/7] x86/mm: remove pgd_leaf definition in arch David Hildenbrand
2025-04-01 14:03   ` Oscar Salvador
2025-04-02  3:39     ` Baoquan He
2025-04-01 20:53   ` [tip: x86/mm] x86/mm: Simplify the pgd_leaf() and p4d_leaf() checks a bit tip-bot2 for Baoquan He
2025-04-01 20:53   ` [tip: x86/mm] x86/mm: Remove the arch-specific pgd_leaf() definition tip-bot2 for Baoquan He
2025-04-01 21:03   ` tip-bot2 for Baoquan He [this message]
2025-03-31  8:13 ` [PATCH v2 6/7] x86/mm: remove p4d_leaf definition Baoquan He
2025-03-31  9:57   ` Ingo Molnar
2025-03-31 14:20     ` Baoquan He
2025-04-01  7:20       ` Ingo Molnar
2025-04-03 13:44         ` Baoquan He
2025-03-31 10:25   ` [tip: x86/mm] x86/mm: Remove the arch-specific p4d_leaf() definition tip-bot2 for Baoquan He
2025-04-01 14:05   ` [PATCH v2 6/7] x86/mm: remove p4d_leaf definition Oscar Salvador
2025-04-01 20:53   ` [tip: x86/mm] x86/mm: Remove the arch-specific p4d_leaf() definition tip-bot2 for Baoquan He
2025-04-01 21:03   ` tip-bot2 for Baoquan He
2025-03-31  8:13 ` [PATCH v2 7/7] mm/pgtable: remove unneeded pgd_devmap() Baoquan He
2025-04-01  8:21   ` David Hildenbrand
2025-04-02  3:33     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174354142637.14745.6334396639863551404.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=bhe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®