From: "Rob Herring (Arm)" <robh@kernel.org>
To: Christian Bruel <christian.bruel@foss.st.com>
Cc: devicetree@vger.kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com,
linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org,
tglx@linutronix.de, krzk+dt@kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, maz@kernel.org
Subject: Re: [PATCH 0/3] Add ST STM32MP2 GICv2 quirk for EOI split mode
Date: Thu, 03 Apr 2025 09:35:34 -0500 [thread overview]
Message-ID: <174369066487.2789685.6006460527429704975.robh@kernel.org> (raw)
In-Reply-To: <20250403122805.1574086-1-christian.bruel@foss.st.com>
On Thu, 03 Apr 2025 14:28:02 +0200, Christian Bruel wrote:
> When using GIC EOI split mode, GICC_DIR fails to deactivate the interrupt,
> leading to a WFI freeze. On ST MP2, GIC cpu interface is limitted to 4K,
> thus GICC_DIR register is reachable with a 0x10000 remapping
>
> When using GIC EOI split mode, the GICC_DIR fails to deactivate the
> interrupt, causing core freeze on WFI. On the ST MP2, the GIC CPU interface
> is limited to 4K, so the GICC_DIR register can be accessed remapping the
> register to a 0x10000 offset.
>
> Christian Bruel (3):
> dt-bindings: interrupt-controller: arm,gic: Add
> st,stm32mp2-cortex-a7-gic
> irqchip/gic: Use 0x10000 offset to access GICC_DIR
> arm64: dts: st: add st,stm32mp2-cortex-a7-gic in intc node in
> stm32mp251.dtsi
>
> .../interrupt-controller/arm,gic.yaml | 1 +
> arch/arm64/boot/dts/st/stm32mp251.dtsi | 2 +-
> drivers/irqchip/irq-gic.c | 47 ++++++++++++++++++-
> 3 files changed, 48 insertions(+), 2 deletions(-)
>
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250403 (exact match)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/st/' for 20250403122805.1574086-1-christian.bruel@foss.st.com:
arch/arm64/boot/dts/st/stm32mp257f-dk.dtb: interrupt-controller@4ac00000: compatible: 'oneOf' conditional failed, one must be fixed:
['st,stm32mp2-cortex-a7-gic', 'arm,cortex-a7-gic'] is too long
arch/arm64/boot/dts/st/stm32mp257f-dk.dtb: interrupt-controller@4ac00000: compatible: 'oneOf' conditional failed, one must be fixed:
['st,stm32mp2-cortex-a7-gic', 'arm,cortex-a7-gic'] is too long
'nvidia,tegra210-agic' was expected
'st,stm32mp2-cortex-a7-gic' is not one of ['nvidia,tegra186-agic', 'nvidia,tegra194-agic', 'nvidia,tegra234-agic']
'arm,gic-400' was expected
'arm,arm1176jzf-devchip-gic' was expected
'brcm,brahma-b15-gic' was expected
'arm,arm11mp-gic' was expected
'arm,cortex-a15-gic' was expected
from schema $id: http://devicetree.org/schemas/interrupt-controller/arm,gic.yaml#
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: interrupt-controller@4ac00000: compatible: 'oneOf' conditional failed, one must be fixed:
['st,stm32mp2-cortex-a7-gic', 'arm,cortex-a7-gic'] is too long
arch/arm64/boot/dts/st/stm32mp257f-ev1.dtb: interrupt-controller@4ac00000: compatible: 'oneOf' conditional failed, one must be fixed:
['st,stm32mp2-cortex-a7-gic', 'arm,cortex-a7-gic'] is too long
'nvidia,tegra210-agic' was expected
'st,stm32mp2-cortex-a7-gic' is not one of ['nvidia,tegra186-agic', 'nvidia,tegra194-agic', 'nvidia,tegra234-agic']
'arm,gic-400' was expected
'arm,arm1176jzf-devchip-gic' was expected
'brcm,brahma-b15-gic' was expected
'arm,arm11mp-gic' was expected
'arm,cortex-a15-gic' was expected
from schema $id: http://devicetree.org/schemas/interrupt-controller/arm,gic.yaml#
prev parent reply other threads:[~2025-04-03 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 12:28 Christian Bruel
2025-04-03 12:28 ` [PATCH 1/3] dt-bindings: interrupt-controller: arm,gic: Add st,stm32mp2-cortex-a7-gic Christian Bruel
2025-04-03 12:28 ` [PATCH 2/3] irqchip/gic: Use 0x10000 offset to access GICC_DIR on STM32MP2 Christian Bruel
2025-04-03 15:43 ` Thomas Gleixner
2025-04-04 12:25 ` Christian Bruel
2025-04-03 17:50 ` Marc Zyngier
2025-04-04 12:15 ` Christian Bruel
2025-04-04 13:36 ` Marc Zyngier
2025-04-04 16:18 ` Christian Bruel
2025-04-04 16:19 ` Christian Bruel
2025-04-03 12:28 ` [PATCH 3/3] arm64: dts: st: add st,stm32mp2-cortex-a7-gic in intc node in stm32mp251.dtsi Christian Bruel
2025-04-03 17:27 ` Marc Zyngier
2025-04-04 12:17 ` Christian Bruel
2025-04-04 12:45 ` Marc Zyngier
2025-04-03 14:35 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174369066487.2789685.6006460527429704975.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=christian.bruel@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maz@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®