From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932941AbbKFAFK (ORCPT ); Thu, 5 Nov 2015 19:05:10 -0500 Received: from mail-yk0-f169.google.com ([209.85.160.169]:35189 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932560AbbKFAFH (ORCPT ); Thu, 5 Nov 2015 19:05:07 -0500 From: Paul Moore To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, v.rathor@gmail.com Subject: Re: [RFC PATCH 4/7] audit: wake up threads if queue switched from limited to unlimited Date: Thu, 05 Nov 2015 19:05:05 -0500 Message-ID: <17437322.gt1f2pcy05@sifl> User-Agent: KMail/4.14.10 (Linux/4.2.3-gentoo; KDE/4.14.13; x86_64; ; ) In-Reply-To: <8a0bd940090b5c4cc19869c6126bdcc85e3be940.1445539473.git.rgb@redhat.com> References: <8a0bd940090b5c4cc19869c6126bdcc85e3be940.1445539473.git.rgb@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, October 22, 2015 02:53:17 PM Richard Guy Briggs wrote: > If the audit_backlog_limit is changed from a limited value to an > unlimited value (zero) while the queue was overflowed, wake up the > audit_backlog_wait queue to allow those processes to continue. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Looks like the right thing to do, merged to audit#next-queue. > diff --git a/kernel/audit.c b/kernel/audit.c > index 384a1a1..02a5ec0 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -523,7 +523,8 @@ static int kauditd_thread(void *dummy) > skb = skb_dequeue(&audit_skb_queue); > > if (skb) { > - if (skb_queue_len(&audit_skb_queue) <= audit_backlog_limit) > + if (!audit_backlog_limit || > + (skb_queue_len(&audit_skb_queue) <= audit_backlog_limit)) > wake_up(&audit_backlog_wait); > if (audit_pid) > kauditd_send_skb(skb); -- paul moore www.paul-moore.com