From: "Rob Herring (Arm)" <robh@kernel.org>
To: Sukrut Bellary <sbellary@baylibre.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
Michael Turquette <mturquette@baylibre.com>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-clk@vger.kernel.org, Tero Kristo <kristo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: clock: ti: Convert to yaml
Date: Fri, 04 Apr 2025 09:56:01 -0500 [thread overview]
Message-ID: <174377855887.1313159.8477749895324191477.robh@kernel.org> (raw)
In-Reply-To: <20250404014500.2789830-3-sbellary@baylibre.com>
On Thu, 03 Apr 2025 18:44:58 -0700, Sukrut Bellary wrote:
> This binding doesn't define a new clock binding type,
> it is used to group the existing clock nodes under the hardware hierarchy.
>
> As this is not a provider clock, remove #clock-cells and
> clock-output-names properties.
> Though few clockdomain nodes in the dts use these properties,
> we are not fixing dts here.
> Clean up the example to meet the current standards.
>
> Add the creator of the original binding as a maintainer.
>
> Signed-off-by: Sukrut Bellary <sbellary@baylibre.com>
> ---
> .../bindings/clock/ti/clockdomain.txt | 25 ------------
> .../bindings/clock/ti/ti,clockdomain.yaml | 38 +++++++++++++++++++
> 2 files changed, 38 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/ti/clockdomain.txt
> create mode 100644 Documentation/devicetree/bindings/clock/ti/ti,clockdomain.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/clock/ti/fixed-factor-clock.txt references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/autoidle.txt
Warning: Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/autoidle.txt
Warning: Documentation/devicetree/bindings/clock/ti/ti,gate-clock.yaml references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/clockdomain.txt
Warning: Documentation/translations/ja_JP/process/submit-checklist.rst references a file that doesn't exist: Documentation/translations/ja_JP/SubmitChecklist
Documentation/devicetree/bindings/clock/ti/fixed-factor-clock.txt: Documentation/devicetree/bindings/clock/ti/autoidle.txt
Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml: Documentation/devicetree/bindings/clock/ti/autoidle.txt
Documentation/devicetree/bindings/clock/ti/ti,gate-clock.yaml: Documentation/devicetree/bindings/clock/ti/clockdomain.txt
Documentation/translations/ja_JP/process/submit-checklist.rst: Documentation/translations/ja_JP/SubmitChecklist
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250404014500.2789830-3-sbellary@baylibre.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-04-04 14:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 1:44 [PATCH 0/4] dt-bindings: clock: ti: convert " Sukrut Bellary
2025-04-04 1:44 ` [PATCH 1/4] dt-bindings: clock: ti: Convert " Sukrut Bellary
2025-04-04 10:44 ` Krzysztof Kozlowski
2025-04-05 19:55 ` Andreas Kemnade
2025-04-09 8:11 ` Sukrut Bellary
2025-04-09 7:46 ` Sukrut Bellary
2025-04-04 15:19 ` Rob Herring
2025-04-09 8:21 ` Sukrut Bellary
2025-04-04 1:44 ` [PATCH 2/4] " Sukrut Bellary
2025-04-04 5:51 ` kernel test robot
2025-04-04 10:46 ` Krzysztof Kozlowski
2025-04-09 8:23 ` Sukrut Bellary
2025-04-04 14:56 ` Rob Herring (Arm) [this message]
2025-04-09 8:35 ` Sukrut Bellary
2025-04-09 9:10 ` Andreas Kemnade
2025-04-10 17:49 ` Sukrut Bellary
2025-04-04 1:44 ` [PATCH 3/4] dt-bindings: clock: ti: Convert fixed-factor-clock " Sukrut Bellary
2025-04-04 19:40 ` Rob Herring
2025-04-09 8:38 ` Sukrut Bellary
2025-04-04 1:45 ` [PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference Sukrut Bellary
2025-04-04 19:42 ` Rob Herring
2025-04-09 8:40 ` Sukrut Bellary
2025-04-05 19:49 ` Andreas Kemnade
2025-04-09 8:43 ` Sukrut Bellary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174377855887.1313159.8477749895324191477.robh@kernel.org \
--to=robh@kernel.org \
--cc=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sbellary@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®