From: Johannes Berg <johannes@sipsolutions.net>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>,
richard@nod.at, anton.ivanov@cambridgegreys.com
Cc: linux-kernel@vger.kernel.org, linux-um@lists.infradead.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH] um: Add winch to winch_handlers before registering winch IRQ
Date: Thu, 28 Mar 2024 09:25:46 +0100 [thread overview]
Message-ID: <1743ad022502d64042fa7db4d847a988bb90cbdc.camel@sipsolutions.net> (raw)
In-Reply-To: <20240307104926.3531358-1-roberto.sassu@huaweicloud.com>
On Thu, 2024-03-07 at 11:49 +0100, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> Registering a winch IRQ is racy, an interrupt may occur before the winch is
> added to the winch_handlers list.
>
> If that happens, register_winch_irq() adds to that list a winch that is
> scheduled to be (or has already been) freed, causing a panic later in
> winch_cleanup().
>
> Avoid the race by adding the winch to the winch_handlers list before
> registering the IRQ, and rolling back if um_request_irq() fails.
>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
johannes
next prev parent reply other threads:[~2024-03-28 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 10:49 Roberto Sassu
2024-03-07 12:43 ` Roberto Sassu
2024-03-28 8:11 ` Roberto Sassu
2024-03-28 8:25 ` Johannes Berg [this message]
2024-04-23 7:22 ` Roberto Sassu
2024-04-23 8:11 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1743ad022502d64042fa7db4d847a988bb90cbdc.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anton.ivanov@cambridgegreys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®