From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 654BB342510 for ; Thu, 19 Feb 2026 15:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513687; cv=none; b=cZa+KT4yKuE0WctSMlkXZsfyfrxZzJqiii7C01pr9eYwTIgtO3Y0gz8qguUacvHZEz3/Pj6/gvSnPDkCIzW9gfQOLY6CsqRR02WqBO/JKJjPgvpTyLihB2/nAS278pyNghRSGL7V78+Nc1Q6TrfM6eRBof+vlIH8hrKEHjB50lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513687; c=relaxed/simple; bh=EVoihKojuEBgZvFeCFVGBiCKXa/yYEOx+jT8RfWk3xE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n8uUSqzc08S557pgjJo+Ic5AuG2rwehF4rHSgF8MSLsUyGj6PB1GNv1swMdZxfWHQB26quon2/9G7uFGeZrvpa+Ex2zR0Cp9O7RCk1AMBgV18mTpw8ziFqEpl7TAgxq9v4T84OqvrX131iH5XA8Sj+iUsL1NA/FlFJkDt3vuUjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N9rVdHli; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QNGXRedF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N9rVdHli"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QNGXRedF" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61JD3LxA160255 for ; Thu, 19 Feb 2026 15:08:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= T7C6zI9G/gF88X8eI0AyLZyqP690jcfAito++UcfSEc=; b=N9rVdHli2mD/kbKi cpFSX/VWgXg4+hiKZ5Ch8jmeBwELz5PtH3cglBYmBoOe+oxL4O1GyEpV/YboWXKO sAAgaN2i5gNWAmFcf+s48n20WGopMCETeTMds5D/TLmPem98uXvLaQNnCdsAes/3 pDEGU56gGZUmQbu85jeimLkV0G0j2h5R+8ly8xy4JLPT50gerzo/teBq5nQfS7HW 3EnrQ0pZxCpga0MWmRrN3odA2eH/9BQ2Dz/ofmTFSKMk8yJTeFab7RFmylOOOeVU 8Xocul1/mDj/UvM9ndef1n9+/8Zgt2WwwL+EJl9vv4j28dvTszPqLRWsAzUw7UaS pxSKug== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cdrpg9v7s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 15:08:05 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5fde699764bso153070137.1 for ; Thu, 19 Feb 2026 07:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771513685; x=1772118485; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T7C6zI9G/gF88X8eI0AyLZyqP690jcfAito++UcfSEc=; b=QNGXRedF5H6aRb7irHyylJWsMWjvpShIM+iiJ/HuHosmIyurLq3hqzlR+3suPiUj5s jOOUTtNGG+AV3TpA0KKItrgbKGV+ayLfOZKOTPivS/gfaJsvJys9ckkX8e7hUzQrCs/U /qDEMGYbPUzj3W1Fg4Luy3s+6TKE7PiIDmPLU4QqlQKr1OP9QbeC9u+q9CAIwvL2OOx8 Fnd5XT1C5iFIVHR/L3pf/h7A7DK1opjlDgLx07Y9cllhijj0U8LycMtTqwcAfsU50MMw iJqnlv47wpbINwFtlYhJmBQcQ9y+5BrRnCUxMSyOHSOjxjQP5tvzozqLne5l72cHTtQI JtNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771513685; x=1772118485; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T7C6zI9G/gF88X8eI0AyLZyqP690jcfAito++UcfSEc=; b=cb1K+ZhaJkK9rVkizN5BsQjm+ceendT49UMbsRuP3cY+/mxw7ndaF6Xj+P5tCEuKYE qcPjc/tWsHy3fSaKb4+qM7u9tszT6DdokmkYVetkL3TcQxEVvLM0WYXG3AqaCoIYqRf+ yV0ddH+RsbnU8Oi9W5B0uDSpgmpJ3+C2dNRUi6qLCH+4LSKPsP9HJTHS/Ky549ra2zP+ LO196o/34zf/AbdMgT5ABGAcZCtVtC0eoNLHqyyGmK51DS4kEOIczOVnZkPbzZ5HRcE1 DOnqrh1LdPlD76wBhwjXVhEjlLCdbphOiRdLzEt1hNyo46M776Pqdv2B0MoZieYPYO/f tW9A== X-Forwarded-Encrypted: i=1; AJvYcCUzXVTM8VdPdO1zIJvY9+ieXbfHMtdZqXnx+MbhYoFXAVMlPuqEsZDhfrcUH2tZzvkH/jo4whHM7RBYf8I=@vger.kernel.org X-Gm-Message-State: AOJu0YxlqeiA9+MioXBzBA8E6BWHkObMik3aq1vRxxHrGZ8uuXMuCtsT puxvnS6ZjmWE5u79OzIWq6JFt96xx3FpTytrXhWcDCh8IfPk8CqvH4bPBYJ+gKOWeCzX9dF/K61 8wj1tntNk7fNlfq4Pr1e5gHAbKX64P0cj7mIzqUTXWiUQghg/1b0/qS27mon+mONea5w= X-Gm-Gg: AZuq6aJetvpbUGu+fozBa7cQEqs5dyiG6HBrMPE/8kO7ufwChcvF5vi1wfkirDrb5Mo m13/inYfiKINABRgb9QwJJxeNf/cDCRUOpfq0zjPtToO927iHOTHnfv/uqQWouVCJLgYYZ/uzZI psGDtVvGVaMiNYnLoBtC63kyJxdj0ZDCSxwyeXpJS1C05dvYimhvn4kvAODeBpf2Y1PAYH8QSo9 D8ZYjc7vBFVfM9VDq+vcSrtWLhiaY4aOa1UyhQk/6uoLcwVHWO9HY9396iqiRVP3nQ6OiInUCCs 4aOlp6CMKsi0SzCODF14xd8ccsKkN/8fbam7LOMReSjjAed9ZzEzD599D4lDzV/GGnT08qE6rNd GkMaVsORMj5xIgSDc0cXQzw1LTsYTPDwZ9/ZC12nzN8CmzwJN+3igg4H3I/E3ABLuMPYKVjNj7Q /iM80= X-Received: by 2002:a05:6102:d8e:b0:5fd:a537:a776 with SMTP id ada2fe7eead31-5fe16f8883amr4495392137.8.1771513684630; Thu, 19 Feb 2026 07:08:04 -0800 (PST) X-Received: by 2002:a05:6102:d8e:b0:5fd:a537:a776 with SMTP id ada2fe7eead31-5fe16f8883amr4495354137.8.1771513684041; Thu, 19 Feb 2026 07:08:04 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc73f7c24sm587514366b.30.2026.02.19.07.08.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 07:08:03 -0800 (PST) Message-ID: <17440856-79c1-4ded-a48a-701e66dfb3a6@oss.qualcomm.com> Date: Thu, 19 Feb 2026 16:07:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 06/13] soc: qcom: geni-se: Introduce helper API for attaching power domains To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-7-praveen.talari@oss.qualcomm.com> <119f619e-9f3d-4c21-8cf1-a8b4e1024ed2@oss.qualcomm.com> <6acfbc33-cdeb-44ce-8f80-90dc18573464@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6acfbc33-cdeb-44ce-8f80-90dc18573464@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: h7deR1NEa7APKKwIugcocn70aoRE-rxY X-Authority-Analysis: v=2.4 cv=JrL8bc4C c=1 sm=1 tr=0 ts=69972755 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=aPOBDM_AZRC3x_6TR8oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDEzOCBTYWx0ZWRfXwVTiIsbO3hZh RxOujGetv4LCBrn93VrlUmBnwjEOFWvxlAjDgQWa7QYTKzifNd7zJi9Zr43N1PiCGdkECdp+ySb EC1hG56b9QsjKqdQdNXigckuwJJyMHS44WSk2J6FDqJBt2hnLdD9qNxawt0fKbWEgkQEJn0DEBS rxJuwXQ1Zz7xJ/HSLZixFsXp0F49cmWhWUWa+POQqVHOCSxylIBcnH7ze0NMx8vtJKu6dNNiS0k OtlId9qaeMB6IhPMp5ESDA6GY59ghGu0eADGg1IIvk5TSVaP7lJ8g2kBwEufBqSSXZ1ZOMRz5S0 7kUcygLZc5/LjRit7lnRSJ6blbGpO6OENnNz8fQEPCwKcDu+Y33wuOJyR7xsXFV678bc4YZvSRm dyhortdu1WF+Zm6RX1EGwP758HHb8sU5wC9giO1Vy4H3qZRgSmZ+OMbHLWF636iFHF6uWTz3mpU V4BRI8F/8iMArgQVwag== X-Proofpoint-ORIG-GUID: h7deR1NEa7APKKwIugcocn70aoRE-rxY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_04,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190138 On 2/19/26 3:58 PM, Praveen Talari wrote: > Hi > > On 2/17/2026 5:09 PM, Konrad Dybcio wrote: >> On 2/6/26 6:41 PM, Praveen Talari wrote: >>> The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle >>> the attachment of power domains. This often leads to duplicated code >>> logic across different driver probe functions. >>> >>> Introduce a new helper API, geni_se_domain_attach(), to centralize >>> the logic for attaching "power" and "perf" domains to the GENI SE >>> device. >>> >>> Signed-off-by: Praveen Talari >>> --- >> >> [...] >> >>> +int geni_se_domain_attach(struct geni_se *se) >>> +{ >>> +    struct dev_pm_domain_attach_data pd_data = { >>> +        .pd_flags = PD_FLAG_DEV_LINK_ON, >>> +        .pd_names = (const char*[]) { "power", "perf" }, >>> +        .num_pd_names = 2, >>> +    }; >>> +    int ret; >>> + >>> +    ret = devm_pm_domain_attach_list(se->dev, >>> +                     &pd_data, &se->pd_list); >>> +    if (ret <= 0) >>> +        return -EINVAL; >> >> I think we should preserve the original retval for the < 0 cases >> >> For == 0, this can mean a number of different things.. but in this >> specific case (where we always set pd_data.num_pd_names == 2) it seems >> that it would only be an issue if dev->of_node == NULL, at which point >> this function would have never been called > > I hope the below is acceptable. > > +int geni_se_domain_attach(struct geni_se *se) > +{ > +       struct dev_pm_domain_attach_data pd_data = { > +               .pd_flags = PD_FLAG_DEV_LINK_ON, > +               .pd_names = (const char*[]) { "power", "perf" }, > +               .num_pd_names = 2, > +       }; > +       int ret; > + > +       ret = devm_pm_domain_attach_list(se->dev, > +                                        &pd_data, &se->pd_list); > +       if (ret == 0) > +               return -ENODEV; > +       else if (ret < 0) > +               return ret; Yeah, thanks! Konrad