From: Leon Romanovsky <leon@kernel.org>
To: jgg@ziepe.ca, phaddad@nvidia.com, markzhang@nvidia.com,
Sharath Srinivasan <sharath.srinivasan@oracle.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, haakon.bugge@oracle.com,
aron.silverton@oracle.com
Subject: Re: [PATCH v2] RDMA/cma: Fix workqueue crash in cma_netevent_work_handler
Date: Wed, 09 Apr 2025 07:20:34 -0400 [thread overview]
Message-ID: <174419763484.373763.12978802764991350026.b4-ty@kernel.org> (raw)
In-Reply-To: <bf0082f9-5b25-4593-92c6-d130aa8ba439@oracle.com>
On Wed, 26 Mar 2025 14:05:32 -0700, Sharath Srinivasan wrote:
> struct rdma_cm_id has member "struct work_struct net_work"
> that is reused for enqueuing cma_netevent_work_handler()s
> onto cma_wq.
>
> Below crash[1] can occur if more than one call to
> cma_netevent_callback() occurs in quick succession,
> which further enqueues cma_netevent_work_handler()s for the
> same rdma_cm_id, overwriting any previously queued work-item(s)
> that was just scheduled to run i.e. there is no guarantee
> the queued work item may run between two successive calls
> to cma_netevent_callback() and the 2nd INIT_WORK would overwrite
> the 1st work item (for the same rdma_cm_id), despite grabbing
> id_table_lock during enqueue.
>
> [...]
Applied, thanks!
[1/1] RDMA/cma: Fix workqueue crash in cma_netevent_work_handler
https://git.kernel.org/rdma/rdma/c/052996ebc39e3e
Best regards,
--
Leon Romanovsky <leon@kernel.org>
next prev parent reply other threads:[~2025-04-09 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 21:05 Sharath Srinivasan
2025-04-08 13:17 ` Haakon Bugge
2025-04-09 11:22 ` Leon Romanovsky
2025-04-09 11:20 ` Leon Romanovsky [this message]
2025-04-09 16:39 ` Sharath Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174419763484.373763.12978802764991350026.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=aron.silverton@oracle.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=sharath.srinivasan@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®