From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758697Ab3BVUx5 (ORCPT ); Fri, 22 Feb 2013 15:53:57 -0500 Received: from hydra.sisk.pl ([212.160.235.94]:41675 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757322Ab3BVUxz (ORCPT ); Fri, 22 Feb 2013 15:53:55 -0500 From: "Rafael J. Wysocki" To: Thomas Gleixner Cc: Yinghai Lu , LKML , Toshi Kani , Huang Ying , ACPI Devel Maling List Subject: Re: [BUG bisected]: apei_hest_parse explosion Date: Fri, 22 Feb 2013 22:00:35 +0100 Message-ID: <1744414.jv1oTA61l1@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.8.0; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: <5350252.GArARx6b7p@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, February 22, 2013 03:39:44 PM Thomas Gleixner wrote: > On Fri, 22 Feb 2013, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Subject: ACPI / APEI: Fix crash in apei_hest_parse() for acpi=off > > > > After commit 92ef2a2 (ACPI: Change the ordering of PCI root bridge > > driver registrarion), acpi_hest_init() is never called for acpi=off > > (acpi_disabled), so hest_disable is not set, but hest_tab is NULL, > > which causes apei_hest_parse() to crash when it is called from > > aer_acpi_firmware_first(). > > > > Fix that by making apei_hest_parse() check if hest_tab is not NULL > > in addition to checking hest_disable. Also remove the now useless > > acpi_disabled check from apei_hest_parse(). > > > > Reported-by: Thomas Gleixner > > Signed-off-by: Rafael J. Wysocki > > Tested-by: Thomas Gleixner Thanks!