From: Bjorn Andersson <andersson@kernel.org>
To: mturquette@baylibre.com, sboyd@kernel.org,
Wentao Liang <vulab@iscas.ac.cn>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: Fix missing error check for dev_pm_domain_attach()
Date: Wed, 16 Apr 2025 13:10:46 -0500 [thread overview]
Message-ID: <174482704420.446874.1566095107641115785.b4-ty@kernel.org> (raw)
In-Reply-To: <20250211092017.562-1-vulab@iscas.ac.cn>
On Tue, 11 Feb 2025 17:20:17 +0800, Wentao Liang wrote:
> In the current implementation, the return value of dev_pm_domain_attach()
> is not checked. This can lead to silent failures if the function fails,
> as the code would continue execution and return 0, ignoring the error.
>
> This patch adds a check for the return value of dev_pm_domain_attach().
> If the function fails, an error message is logged using dev_err_probe(),
> and the error is propagated to the existing error handling path `err`,
> which ensures proper cleanup by calling clk_notifier_unregister().
>
> [...]
Applied, thanks!
[1/1] clk: qcom: Fix missing error check for dev_pm_domain_attach()
commit: 36eb51ac8bd545b6344c05a9860e4e65ba8d7a62
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2025-04-16 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 9:20 Wentao Liang
2025-02-12 14:45 ` Markus Elfring
2025-04-16 18:10 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174482704420.446874.1566095107641115785.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®